Skip to content

Conversation

@kadhirash
Copy link

Addresses #580

Changes getDNSForSite to getDnsForSite and configureDNSForSite to configureDnsForSite to match the naming convention used by all other Dns-related operations (e.g., getDnsZone, createDnsZone, deleteDnsZone, etc.).

This ensures consistent camelCase naming across the API and prevents confusion when switching between different Dns-related methods.

Changes:

  • Updated 2 operation IDs in swagger.yml
  • All tests passing ✅

Note:

  • The Go client files will need to be regenerated by maintainers after merge (as mentioned in CONTRIBUTING.md).

@kadhirash kadhirash requested review from a team as code owners November 3, 2025 20:59
@kadhirash
Copy link
Author

Hey @VitaliyR or @kathmbeck, are you able to take a look? Thank you

Copy link
Contributor

@VitaliyR VitaliyR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for the PR!

This rename will bring a breaking change to the clients, something we are not prioritising right now.

@kadhirash kadhirash closed this Nov 12, 2025
@kadhirash
Copy link
Author

@VitaliyR ah okay no worries, saw it in one of the issues and wanted to fix it. I'll close it for now then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants