-
Notifications
You must be signed in to change notification settings - Fork 17
Bug/network type switch crash swift logs #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mlsmaycon
wants to merge
34
commits into
main
Choose a base branch
from
bug/network-type-switch-crash-swift-logs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
a1e2af0
Add completion handler usage when restarting client
doromaraujo 08c206e
Fix UI stuck in connecting state during network type switches
mlsmaycon a3f6cb4
add build and test workflows and handle missing firebase files
mlsmaycon a52f02e
update jobs and docs with build script
mlsmaycon cf6f3a2
fix paths
mlsmaycon ae948b9
fix PeerCard.swift ref
mlsmaycon da6bbe9
fix comments
mlsmaycon f22e1db
remove network extension refs
mlsmaycon 4251fc7
Removed PBXBuildFile references
mlsmaycon 28ddad6
use newer xcode
mlsmaycon 08093a7
handle airplane mode
mlsmaycon 62659ac
remove xcode selection
mlsmaycon aada818
address comments
mlsmaycon 303ea9d
use macos-14
mlsmaycon 8743371
use a subdirectory
mlsmaycon 4a54da7
use a subdirectory in test
mlsmaycon a30ea8e
improve reliability when handling auth
mlsmaycon 0a16812
Removed Firebase initialization in networkextension
mlsmaycon ed7ec21
remove mac designed for ipad support from gui
mlsmaycon bd521b0
fix readme version
mlsmaycon 4177849
add popoverPresentationController when running on ipad
mlsmaycon 6defc9f
Uses temporary directory instead of Documents
mlsmaycon bf1225c
Removed the misleading comment about onConnected()
mlsmaycon 0aee71b
Added fallback to Documents directory when App Group is unavailable
mlsmaycon d69a8cf
Added tests
mlsmaycon 242a463
Added workflow permissions
mlsmaycon 5f83261
handle potential nil in tests
mlsmaycon b369f73
handle airplane mode freezes
mlsmaycon 1028f7c
fix comment
mlsmaycon 50b0165
update airplane mode handler
mlsmaycon e935811
build 9
mlsmaycon a07b82d
remove print and reduce max log app size to 100kb
mlsmaycon dc70b66
fix comments
mlsmaycon e24dce4
build 10
mlsmaycon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| name: Build | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| build: | ||
| name: Build iOS App | ||
| runs-on: macos-14 | ||
|
|
||
| steps: | ||
| - name: Checkout ios-client | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Checkout netbird | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: netbirdio/netbird | ||
| path: netbird | ||
|
|
||
| - name: Setup Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: '1.24' | ||
| cache-dependency-path: netbird/go.sum | ||
|
|
||
| - name: Install gomobile | ||
| run: go install golang.org/x/mobile/cmd/gomobile@v0.0.0-20251113184115-a159579294ab | ||
|
|
||
| - name: Build NetBirdSDK xcframework | ||
| run: ./build-go-lib.sh $PWD/netbird | ||
|
|
||
| - name: Select Xcode | ||
| run: sudo xcode-select -s /Applications/Xcode_16.1.app | ||
|
|
||
| - name: Install xcpretty | ||
| run: gem install xcpretty | ||
|
|
||
| - name: Resolve Swift packages | ||
| run: | | ||
| xcodebuild -resolvePackageDependencies \ | ||
| -project NetBird.xcodeproj \ | ||
| -scheme NetBird | ||
|
|
||
| - name: Build iOS App | ||
| run: | | ||
| set -o pipefail | ||
| xcodebuild build \ | ||
| -project NetBird.xcodeproj \ | ||
| -scheme NetBird \ | ||
| -destination 'generic/platform=iOS' \ | ||
| -configuration Debug \ | ||
| CODE_SIGNING_ALLOWED=NO \ | ||
| CODE_SIGNING_REQUIRED=NO \ | ||
| CODE_SIGN_IDENTITY="" \ | ||
| | xcpretty --color | ||
|
|
||
| - name: Build Network Extension | ||
| run: | | ||
| set -o pipefail | ||
| xcodebuild build \ | ||
| -project NetBird.xcodeproj \ | ||
| -scheme NetbirdNetworkExtension \ | ||
| -destination 'generic/platform=iOS' \ | ||
| -configuration Debug \ | ||
| CODE_SIGNING_ALLOWED=NO \ | ||
| CODE_SIGNING_REQUIRED=NO \ | ||
| CODE_SIGN_IDENTITY="" \ | ||
| | xcpretty --color |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| name: Test | ||
|
|
||
| on: | ||
| push: | ||
| branches: [main] | ||
| pull_request: | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| test: | ||
| name: Build for Simulator | ||
| runs-on: macos-14 | ||
|
|
||
| steps: | ||
| - name: Checkout ios-client | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Checkout netbird | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: netbirdio/netbird | ||
| path: netbird | ||
|
|
||
| - name: Setup Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: '1.24' | ||
| cache-dependency-path: netbird/go.sum | ||
|
|
||
| - name: Install gomobile | ||
| run: go install golang.org/x/mobile/cmd/gomobile@v0.0.0-20251113184115-a159579294ab | ||
mlsmaycon marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| - name: Build NetBirdSDK xcframework | ||
| run: ./build-go-lib.sh $PWD/netbird | ||
|
|
||
| - name: Select Xcode | ||
| run: sudo xcode-select -s /Applications/Xcode_16.1.app | ||
|
|
||
| - name: Install xcpretty | ||
| run: gem install xcpretty | ||
|
|
||
| - name: Resolve Swift packages | ||
| run: | | ||
| xcodebuild -resolvePackageDependencies \ | ||
| -project NetBird.xcodeproj \ | ||
| -scheme NetBird | ||
| - name: Build for Simulator | ||
| run: | | ||
| set -o pipefail | ||
| xcodebuild build \ | ||
| -project NetBird.xcodeproj \ | ||
| -scheme NetBird \ | ||
| -destination 'platform=iOS Simulator,name=iPhone 16' \ | ||
| -configuration Debug \ | ||
| CODE_SIGNING_ALLOWED=NO \ | ||
| | xcpretty --color | ||
mlsmaycon marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.