-
Notifications
You must be signed in to change notification settings - Fork 11
Pipeline updates #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Pipeline updates #51
Conversation
| @@ -1,6 +1,7 @@ | |||
| --- | |||
| image: mtarking/nac-vxlan:24.0.1 | |||
| image: danischm/nac:0.1.5 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is old PR and need to test and work on the pipeline again, I was performing a few tests and was facing issue with the ansible version download as per requirement.txt. It was working for the nac:0.1.5 image. Please let me know of I can close this and work on a new PR.
| paths: | ||
| - .pip_cache/ | ||
|
|
||
| setup: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a one time action where you're using this for each stage or does each stage need a before_script:?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to check this again, I remember adding this as subsequent stages were showing error with missing packages.
| when: manual | ||
| script: | ||
| - set -o pipefail && ansible-playbook -i inventory.yml vxlan.yml |& tee deploy_output.txt | ||
| - pip install --cache-dir .pip_cache -r requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe before_script:?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, need to work on this pieline PR again.
| - if: $CI_COMMIT_BRANCH == $CI_DEFAULT_BRANCH | ||
| script: | ||
| - set -o pipefail && iac-test -d ./host_vars/nac-ndfc1 -d ./group_vars/ndfc/defaults.yaml -t ./tests/templates -f ./tests/filters -o ./tests/results/ndfc |& tee test_output.txt | ||
| - pip uninstall -y nac-test || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why uninstall?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the Docker image had nac-test included and it was getting called when we run iac-test, which was causing issues with the robot tests as those are not supported yet for nac-test, so I had to remove this.
| script: | ||
| - set -o pipefail && iac-test -d ./host_vars/nac-ndfc1 -d ./group_vars/ndfc/defaults.yaml -t ./tests/templates -f ./tests/filters -o ./tests/results/ndfc |& tee test_output.txt | ||
| - pip uninstall -y nac-test || true | ||
| - pip install --cache-dir .pip_cache -r requirements.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before_script:?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned above, need to work on this again.
Updating the pipeline to install the ansible collection in the setup stage. As of now it doesn't install ansible collection and requirements so the pipeline is failing.