Skip to content

Conversation

@ObserverOfTime
Copy link
Contributor

No description provided.

@clason
Copy link
Member

clason commented Oct 20, 2024

Can you explain what exactly this workflow does?

@ObserverOfTime
Copy link
Contributor Author

It creates a release with tree-sitter-vimdoc.wasm and tree-sitter-vimdoc.tar.xz (source code plus generated files).

@clason
Copy link
Member

clason commented Oct 20, 2024

why not tar.gz like normal archives?

@ObserverOfTime
Copy link
Contributor Author

To reduce confusion regarding which archive is correct.

@clason
Copy link
Member

clason commented Oct 20, 2024

That just makes it harder to use; I don't think I want this in nvim-treesitter.

@ObserverOfTime
Copy link
Contributor Author

How is it harder to use? Any platform that supports tar.gz also supports tar.xz.

@clason
Copy link
Member

clason commented Oct 20, 2024

Because now I have to maintain two different "extract archive" functions (again, for little good reason).

@ObserverOfTime
Copy link
Contributor Author

You will have to add a flag that controls which archive to download anyway.
That flag can then switch between tar.xz/xvJf and tar.gz/xvzf.

@clason
Copy link
Member

clason commented May 3, 2025

Superseded by #147.

@clason clason closed this May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants