Skip to content

circe: Filter out flat optionals #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2025
Merged

circe: Filter out flat optionals #87

merged 1 commit into from
May 16, 2025

Conversation

@kubukoz
Copy link
Contributor

@kubukoz kubukoz commented May 15, 2025 •
edited
Loading

In the switch to jsoniter-circe in #83, we accidentally started encoding error:null and some implementations don't like that. It's also against the spec:

error
This member is REQUIRED on error.
This member MUST NOT exist if there was no error triggered during invocation.
The value for this member MUST be an Object as defined in section 5.1.

@kubukoz kubukoz changed the title Filter out optionals by default circe: Filter out optionals by default May 15, 2025
@kubukoz kubukoz changed the title circe: Filter out optionals by default circe: Filter out flat optionals May 15, 2025
@ghostbuster91 ghostbuster91 merged commit bec1dca into smithy4s-integration May 16, 2025
2 checks passed
@Baccata Baccata deleted the wrongfully-added-nulls branch May 16, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ghostbuster91 ghostbuster91 ghostbuster91 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kubukoz @ghostbuster91