Skip to content

Errors smithy4s #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
May 15, 2025
Merged

Errors smithy4s #86

merged 14 commits into from
May 15, 2025

Conversation

@ghostbuster91
Copy link
Contributor

@ghostbuster91 ghostbuster91 commented May 14, 2025 •
edited
Loading

summary of changes:

  • scala version bump 3.3.5->3.3.6
  • new module smithy4sTests
  • changed endpoints to accept either Decoder or Encoder depending on the use case
  • added error handling for unknown server errors
  • made Endpoint variants package-private and exposed mapK function to allow changing effects

kubukoz
kubukoz reviewed May 14, 2025
View reviewed changes
@ghostbuster91 ghostbuster91 marked this pull request as ready for review May 15, 2025 10:05
Baccata
Baccata reviewed May 15, 2025
View reviewed changes
modules/core/src/main/scala/jsonrpclib/PolyFunction.scala
package jsonrpclib

trait PolyFunction[F[_], G[_]] { self =>
def apply[A0](fa: => F[A0]): G[A0]
Copy link
Contributor

@Baccata Baccata May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smort 👍

@kubukoz kubukoz merged commit c070f65 into smithy4s-integration May 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kubukoz kubukoz kubukoz left review comments

@Baccata Baccata Baccata left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ghostbuster91 @kubukoz @Baccata