Skip to content

Conversation

@Mahfa
Copy link

@Mahfa Mahfa commented Sep 18, 2023

fix RTL issue

fix RTL issue
@clragon
Copy link
Contributor

clragon commented Nov 6, 2023

Could you explain which issue exactly?
Is there a reason we are adding this Directionality in the screenLock callback instead of inside the ScreenLock widget where we would only need to add it once?

@Mahfa
Copy link
Author

Mahfa commented Nov 6, 2023

@clragon
the issue is when the locale of the material app is set to a rtl locale like "fa" or "ps" the layout of the lock screen is wrong.

Is there a reason we are adding this Directionality in the screenLock callback instead of inside the ScreenLock widget where we would only need to add it once?

no there is not i just added it there for simplicity

@clragon
Copy link
Contributor

clragon commented Nov 6, 2023

Okay, awesome thank you.
Could you in that case move the Directionality widget inside of the ScreenLock widget?
That would be beneficial, I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants