Modernize pre-commit: replace black with ruff, use isort with plone profile #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rofile - Replace black with ruff for linting and formatting - Keep isort for import sorting with plone profile and alphabetical rules - Configure ruff with line-length=120, target Python 3.10+ - Add ruff configuration with appropriate rule selections and ignores - Ignore F841 (unused variables) in tests directory - Fix compatibility issues: - Fix undefined s() function in svn.py (use stderr.decode()) - Fix undefined b() function in test_mercurial.py (use b":" literal) - Update pyproject.toml with ruff and isort configurations - Update Makefile (mxmake auto-updated qa.black -> qa.ruff) - Apply ruff-format and isort to all files This modernizes the tooling stack while keeping the project's code style consistent. Ruff provides faster linting/formatting and better Python 3.10+ support.
- Replace black/flake8 references with ruff - Add ruff linting and formatting commands - Update Code Style section with ruff formatter details - Document isort with plone profile configuration - Add Python 3.10+ type hint syntax examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modernizes the pre-commit configuration by replacing black with ruff for linting and formatting, while keeping isort for import sorting with the plone profile.
Changes
Pre-commit Configuration:
line-length = 120target-version = "py310"Code Quality Fixes:
s()function in svn.py → usestderr.decode()b()function in test_mercurial.py → useb":"literalConfiguration Updates:
Code Formatting:
Benefits
Testing
Related
This builds on PR #63 (Python 3.10+ migration).