-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
TSL Transpiler: Support struct definitions and declarations #32300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ne0nWinds
commented
Nov 17, 2025
Ne0nWinds
commented
Nov 17, 2025
Ne0nWinds
commented
Nov 17, 2025
sunag
reviewed
Nov 19, 2025
sunag
reviewed
Nov 19, 2025
This was referenced Nov 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #30885
Description
This PR adds support for struct definitions/declarations to the TSL transpiler.
Examples
Struct definitions:
Struct Declarations:
Return Values / Input parameters:
Limitations
Struct members can't be properly accessed. Currently, if a struct member is accessed, the transpiler will generate
.memberinstead of.get("member"). In order to do this properly, the transpiler would need proper type resolution. Some type information is available in the linker, but this won't work in the general case.As far as I can tell (and I'm okay being corrected on this), TSL doesn't support structs with array/struct members, so this PR doesn't add support for them.
Despite these limitations, this feature still helps with the discoverability of struct syntax in TSL