-
-
Notifications
You must be signed in to change notification settings - Fork 69
feat: Grant additional access for Groups & Recocile logic for masterRole Changes & Metrics Support #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Grant additional access for Groups & Recocile logic for masterRole Changes & Metrics Support #253
Conversation
… reload when secret changed
Co-authored-by: Pieter C <pieter@buca.be>
c680836 to
6b789fe
Compare
pcallewaert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I like all these improvements. Some feedback added.
Co-authored-by: Pieter C <pieter@buca.be>
1469980 to
738f725
Compare
2216b8c to
d590544
Compare
Thanks for the review. I believe we are ready. |
|
Nice PR, I'm affected by the same |
I am looking forward to being approved and merged. You can take the PR Source Code and do a local Docker build. docker build . -t postgres-operator:v1The next topic on the horizon is the monitoring role. I am still clarifying how is going to look like on my end. |
I notice we are missing sequences and functions access.
The Second Writer-Group should have limited access to Sequences and execute the Functions.
Reader-Group remains the same
Update Owner-Group if the masterRole was renamed or changed
Re-assign the user group membership
Leader election
PodMonitor
Added for Prometheus Operator Discovery
PodMonitor
Enable Metrics