Skip to content

Conversation

@tadjik1
Copy link
Member

@tadjik1 tadjik1 commented Oct 30, 2025

Description

Summary of Changes

Remove test/mongodb.ts and all its' usage across the project (inside test/ folder).

Notes for Reviewers

This PR is pretty straightforward due to all the previous work for removing mongodb-legacy wrapper. And even though this file doesn't have any links to legacy driver usage we agreed to remove this file completely for consistency and readability reasons.

I had to make changes in examples/ folder, which is used by the docs team.

Please see my comments about action/dependency.test.ts updates: these tests are written differently, they run script in a separate nodejs process (using ts-node), and before they were expecting test/mongodb.ts passed as parameter. I changed this behaviour to dynamically import certain entities directly from src folder.

What is the motivation for this change?

Release Highlight

Release notes highlight

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@tadjik1 tadjik1 changed the title test(NODE-7280): remove test/mongodb.ts and its usage [wip] test(NODE-7280): remove test/mongodb.ts and its usage Oct 30, 2025
@tadjik1 tadjik1 changed the title [wip] test(NODE-7280): remove test/mongodb.ts and its usage test(NODE-7280): remove test/mongodb.ts and its usage Oct 30, 2025
@tadjik1 tadjik1 marked this pull request as ready for review October 30, 2025 12:52
@tadjik1 tadjik1 requested a review from a team as a code owner October 30, 2025 12:52
@durran durran self-assigned this Oct 30, 2025
@durran durran added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Oct 30, 2025
@durran durran mentioned this pull request Oct 30, 2025
5 tasks
@durran durran merged commit 7d879fd into main Oct 30, 2025
25 of 27 checks passed
@durran durran deleted the NODE-7280 branch October 30, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants