-
Notifications
You must be signed in to change notification settings - Fork 1.8k
test(NODE-7280): remove test/mongodb.ts and its usage #4766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadjik1
commented
Oct 30, 2025
tadjik1
commented
Oct 30, 2025
tadjik1
commented
Oct 30, 2025
tadjik1
commented
Oct 30, 2025
tadjik1
commented
Oct 30, 2025
tadjik1
commented
Oct 30, 2025
5 tasks
durran
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Remove
test/mongodb.tsand all its' usage across the project (insidetest/folder).Notes for Reviewers
This PR is pretty straightforward due to all the previous work for removing mongodb-legacy wrapper. And even though this file doesn't have any links to legacy driver usage we agreed to remove this file completely for consistency and readability reasons.
I had to make changes in
examples/folder, which is used by the docs team.Please see my comments about
action/dependency.test.tsupdates: these tests are written differently, they run script in a separate nodejs process (using ts-node), and before they were expectingtest/mongodb.tspassed as parameter. I changed this behaviour to dynamically import certain entities directly fromsrcfolder.What is the motivation for this change?
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript