PYTHON-4804 Migrate test_comment.py to async #1887
Conversation
sleepyStick
changed the title
|
Not sure why the link check is failing...I don't think its anything I did? |
No, the docs team is working on a fix |
sleepyStick
force-pushed
the
PYTHON-4804
branch
from
6ceed75 to
f6d2fcd
Compare
sleepyStick
force-pushed
the
PYTHON-4804
branch
from
f6d2fcd to
4120a15
Compare
test/asynchronous/test_comment.py
Outdated
| listener.reset() | ||
| kwargs = {"comment": cc} | ||
| if h == coll.rename: | ||
| _ = await db.get_collection("temp_temp_temp").drop() |
There was a problem hiding this comment.
Is this underscore needed?
There was a problem hiding this comment.
probably not! just removed it :)
test/asynchronous/test_comment.py
Outdated
| if iscoroutinefunction(coll.create_index): | ||
| await coll.create_index("a") | ||
| else: | ||
| coll.create_index("a") |
There was a problem hiding this comment.
| if iscoroutinefunction(coll.create_index): | |
| await coll.create_index("a") | |
| else: | |
| coll.create_index("a") | |
| if not _IS_SYNC and isinstance(coll, Empty): | |
| coll.create_index("a") | |
| else: | |
| await coll.create_index("a") |
For clarity so unfamiliar readers can understand why coll.create_index could be synchronous.
test/asynchronous/test_comment.py
Outdated
| if iscoroutinefunction(h): | ||
| maybe_cursor = await h(*args, **kwargs) | ||
| else: | ||
| maybe_cursor = h(*args, **kwargs) |
There was a problem hiding this comment.
| if iscoroutinefunction(h): | |
| maybe_cursor = await h(*args, **kwargs) | |
| else: | |
| maybe_cursor = h(*args, **kwargs) | |
| if not _IS_SYNC and iscoroutinefunction(h): | |
| maybe_cursor = await h(*args, **kwargs) | |
| else: | |
| maybe_cursor = h(*args, **kwargs) |
Same here.
|
Oops, didn't realize that merging would dismiss the review...sorry! |
test/test_comment.py
Outdated
| _IS_SYNC = True | ||
|
|
||
|
|
||
| class Empty: |
There was a problem hiding this comment.
This Empty class looks very suspicious. What's the point of it?
There was a problem hiding this comment.
Uhhh honestly not sure. It was added in PYTHON-2682.
There was a problem hiding this comment.
cleaned up _test_ops and now Empty isn't needed anymore :)
test/test_comment.py
Outdated
| coll.create_index("a") | ||
| maybe_cursor = h(*args, **kwargs) | ||
| if not _IS_SYNC and isinstance(coll, Empty): | ||
| coll.create_index("a") |
There was a problem hiding this comment.
How can we call create_index when coll is Empty?
There was a problem hiding this comment.
Thats a great question...HAHA code is removed now.
ShaneHarvey
left a comment
ShaneHarvey
left a comment
There was a problem hiding this comment.
LGTM assuming the tests pass.
4 participants
No description provided.