test: VSCode test setup and switch to insiders VSCODE-700

.github/workflows/actions/test-and-build/action.yaml

@@ -68,6 +68,7 @@ runs:
     - name: Run Tests
       env:
         NODE_OPTIONS: "--max_old_space_size=4096"
+        MDB_UNDER_TEST: "true"
       run: |
         npm run test
       shell: bash

.github/workflows/draft-release.yaml

@@ -96,6 +96,7 @@ jobs:
           GARASIGN_USERNAME: ${{ secrets.GARASIGN_USERNAME }}
           SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
           JIRA_API_TOKEN: ${{ secrets.JIRA_API_TOKEN }}
+          MDB_UNDER_TEST: "true"
 
       - name: Create Draft Release
         run: |

.github/workflows/test-and-build-from-fork.yaml

@@ -40,4 +40,5 @@ jobs:
         env:
           NODE_OPTIONS: "--max_old_space_size=4096"
           SEGMENT_KEY: "test-segment-key"
+          MDB_UNDER_TEST: "true"
         run: npm run test

.github/workflows/test-and-build.yaml

@@ -48,3 +48,4 @@ jobs:
           GARASIGN_USERNAME: ${{ secrets.GARASIGN_USERNAME }}
           SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }}
           JIRA_API_TOKEN: ${{ secrets.JIRA_API_TOKEN }}
+          MDB_UNDER_TEST: "true"

.vscode/launch.json

@@ -53,10 +53,11 @@
         "--extensionTestsPath=${workspaceFolder}/out/test/suite"
       ],
       "env": {
-        "MOCHA_GREP": "${input:mochaGrep}"
+        "MOCHA_GREP": "${input:mochaGrep}",
+        "MDB_UNDER_TEST": "true"
       },
       "outFiles": ["${workspaceFolder}/out/**/*.js"],
-      "preLaunchTask": "npm: compile:extension",
+      "preLaunchTask": "npm: compile:extension"
     }
   ],
   "inputs": [

package.json

@@ -52,7 +52,7 @@
     "watch:extension-bundles": "webpack --mode development --watch",
     "pretest": "npm run compile",
     "test": "npm run test-webview && npm run test-extension",
-    "test-extension": "cross-env NODE_OPTIONS=--no-force-async-hooks-checks xvfb-maybe node ./out/test/runTest.js",
+    "test-extension": "cross-env MDB_UNDER_TEST=true NODE_OPTIONS=--no-force-async-hooks-checks xvfb-maybe node ./out/test/runTest.js",
     "test-webview": "mocha -r ts-node/register --grep=\"${MOCHA_GREP}\" --file ./src/test/setup-webview.ts src/test/suite/views/webview-app/**/*.test.tsx",
     "ai-accuracy-tests": "env TS_NODE_FILES=true mocha -r ts-node/register --grep=\"${MOCHA_GREP}\" --file ./src/test/ai-accuracy-tests/test-setup.ts ./src/test/ai-accuracy-tests/ai-accuracy-tests.ts",
     "analyze-bundle": "webpack --mode production --analyze",

src/connectionController.ts

@@ -729,6 +729,7 @@ export default class ConnectionController {
 
     if (!this._activeDataService) {
       log.error('Unable to disconnect: no active connection');
+      this._disconnecting = false;
       return false;
     }
 

src/extension.ts

@@ -21,7 +21,10 @@ debug.log = log.debug.bind(log);
 
 import MDBExtensionController from './mdbExtensionController';
 
-let mdbExtension: MDBExtensionController;
+let mdbExtension: MDBExtensionController | undefined;
+
+const isUnderTest =
+  process.env.NODE_ENV === 'test' || process.env.MDB_UNDER_TEST === 'true';
 
 // Called when our extension is activated.
 // See "activationEvents" in `package.json` for the events that cause activation.
@@ -51,13 +54,24 @@ export async function activate(
     },
   });
 
-  mdbExtension = new MDBExtensionController(context, {
-    shouldTrackTelemetry: true,
-  });
-  await mdbExtension.activate();
+  // Solution to VSCODE-700. If we are running tests, don't activate the extension.
+  // This avoids registering multiple providers when running the tests, which causes errors in recent versions of vscode.
+  if (isUnderTest) {
+    log.info(
+      'Skipping MDBExtensionController activation because MDB_UNDER_TEST is set.',
+    );
+    return;
+  }
 
-  // Add our extension to a list of disposables for when we are deactivated.
-  context.subscriptions.push(mdbExtension);
+  if (!mdbExtension) {
+    mdbExtension = new MDBExtensionController(context, {
+      shouldTrackTelemetry: true,
+    });
+    await mdbExtension.activate();
+
+    // Add our extension to a list of disposables for when we are deactivated.
+    context.subscriptions.push(mdbExtension);
+  }
 }
 
 // Called when our extension is deactivated.

src/test/runTest.ts

@@ -39,7 +39,7 @@ async function main(): Promise<any> {
 
   // Download VS Code, unzip it and run the integration test
   await runTests({
-    version: '1.103.2', // TODO(VSCODE-700) Once we fix the test setup issues, we should revert this to 'insiders'
+    version: 'insiders',
     extensionDevelopmentPath,
     extensionTestsPath,
     launchArgs: [testWorkspace, '--disable-extensions'],

src/test/suite/connectionController.test.ts

@@ -42,7 +42,7 @@ const sleep = (ms: number): Promise<void> => {
 };
 
 suite('Connection Controller Test Suite', function () {
-  this.timeout(5000);
+  this.timeout(10000);
 
   const extensionContextStub = new ExtensionContextStub();
   const testStorageController = new StorageController(extensionContextStub);
@@ -73,6 +73,8 @@ suite('Connection Controller Test Suite', function () {
     extensionContextStub._workspaceState = {};
     extensionContextStub._globalState = {};
 
+    testConnectionController.cancelConnectionAttempt();
+
     await testConnectionController.disconnect();
     testConnectionController.clearAllConnections();
 

src/test/suite/editors/playgroundSelectionCodeActionProvider.test.ts

@@ -3,7 +3,6 @@ import { beforeEach, afterEach } from 'mocha';
 import chai from 'chai';
 import sinon from 'sinon';
 import PlaygroundSelectionCodeActionProvider from '../../../editors/playgroundSelectionCodeActionProvider';
-import { LanguageServerController } from '../../../language';
 import { mdbTestExtension } from '../stubbableMdbExtension';
 import { PlaygroundController } from '../../../editors';
 import { TEST_DATABASE_URI } from '../dbTestHelper';
@@ -32,11 +31,6 @@ suite('Playground Selection Code Action Provider Test Suite', function () {
     let testActiveTextEditor;
 
     beforeEach(async () => {
-      sandbox.replace(
-        mdbTestExtension.testExtensionController,
-        '_languageServerController',
-        new LanguageServerController(extensionContextStub),
-      );
       sandbox.stub(vscode.window, 'showInformationMessage');
       sandbox.stub(
         mdbTestExtension.testExtensionController._telemetryService,
@@ -79,7 +73,6 @@ suite('Playground Selection Code Action Provider Test Suite', function () {
         .getConfiguration('mdb')
         .update('confirmRunAll', false);
 
-      await mdbTestExtension.testExtensionController._languageServerController.startLanguageServer();
       await mdbTestExtension.testExtensionController._playgroundController._activeConnectionChanged();
 
       testActiveTextEditor = sandbox.stub(vscode.window, 'activeTextEditor');

src/test/suite/index.ts

@@ -54,11 +54,21 @@ export async function run(): Promise<void> {
         try {
           // Run the mocha test.
           mocha.run((failures) => {
-            if (failures > 0) {
-              e(new Error(`${failures} tests failed.`));
-            } else {
-              c();
-            }
+            // Deactivate the extension to properly clean up the language server
+            void mdbTestExtension.testExtensionController
+              .deactivate()
+              .then(() => {
+                if (failures > 0) {
+                  e(new Error(`${failures} tests failed.`));
+                } else {
+                  c();
+                }
+              })
+              .catch((deactivateErr) => {
+                console.error('Error deactivating extension:');
+                console.error(deactivateErr);
+                e(deactivateErr);
+              });
           });
         } catch (mochaRunErr) {
           console.error('Error running mocha tests:');

src/test/suite/language/languageServerController.test.ts

@@ -11,7 +11,6 @@ import chaiAsPromised from 'chai-as-promised';
 import PlaygroundSelectionCodeActionProvider from '../../../editors/playgroundSelectionCodeActionProvider';
 import ConnectionController from '../../../connectionController';
 import EditDocumentCodeLensProvider from '../../../editors/editDocumentCodeLensProvider';
-import { LanguageServerController } from '../../../language';
 import { mdbTestExtension } from '../stubbableMdbExtension';
 import { PlaygroundController } from '../../../editors';
 import PlaygroundResultProvider from '../../../editors/playgroundResultProvider';
@@ -21,6 +20,7 @@ import { TEST_DATABASE_URI } from '../dbTestHelper';
 import { TelemetryService } from '../../../telemetry';
 import { ExtensionContextStub } from '../stubs';
 import ExportToLanguageCodeLensProvider from '../../../editors/exportToLanguageCodeLensProvider';
+import type { LanguageServerController } from '../../../language';
 
 const expect = chai.expect;
 
@@ -58,9 +58,9 @@ suite('Language Server Controller Test Suite', () => {
   const sandbox = sinon.createSandbox();
 
   before(async () => {
-    languageServerControllerStub = new LanguageServerController(
-      extensionContextStub,
-    );
+    languageServerControllerStub =
+      mdbTestExtension.testExtensionController._languageServerController;
+
     const testExportToLanguageCodeLensProvider =
       new ExportToLanguageCodeLensProvider(testPlaygroundResultProvider);
 
@@ -73,7 +73,6 @@ suite('Language Server Controller Test Suite', () => {
       playgroundSelectionCodeActionProvider: testCodeActionProvider,
       exportToLanguageCodeLensProvider: testExportToLanguageCodeLensProvider,
     });
-    await languageServerControllerStub.startLanguageServer();
     await testPlaygroundController._activeConnectionChanged();
   });
 

src/test/suite/views/webviewController.test.ts

@@ -157,9 +157,9 @@ suite('Webview Test Suite', () => {
   suite('when oidc device auth flow setting is enabled', function () {
     let originalDeviceAuthFlow;
     before(async function () {
-      originalDeviceAuthFlow = vscode.workspace.getConfiguration(
-        'mdb.showOIDCDeviceAuthFlow',
-      );
+      originalDeviceAuthFlow = vscode.workspace
+        .getConfiguration('mdb')
+        .get('showOIDCDeviceAuthFlow');
 
       await vscode.workspace
         .getConfiguration('mdb')