chore: fix prepublish for node-runtime-worker-thread #2608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes a prepublish issue in the node-runtime-worker-thread package by adding webpack external configurations for package.json imports. The changes ensure that package.json files from external dependencies are properly handled as external modules rather than being bundled.
Key changes:
- Added webpack external configuration for
mongodb-client-encryption/package.json - Added webpack external configuration for
kerberos/package.json
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gagik
added
the
no-title-validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/mongodb-js/mongosh/actions/runs/19892733974
I'm not sure why this broke and if this is the right fix but it works?