Skip to content

Conversation

@addaleax
Copy link
Collaborator

@addaleax addaleax commented Dec 1, 2025

Terminals do not provide an easy way to "push/pop" window titles, so we're basically stuck with clearing the window title when mongosh exits on a best-effort basis.

When somebody brings this up as an issue, we should still recommend them to include something in their shell's .rc file to automatically reset window titles after each shell command.

Terminals do not provide an easy way to "push/pop" window titles,
so we're basically stuck with clearing the window title when mongosh
exits on a best-effort basis.

When somebody brings this up as an issue, we should still recommend
them to include something in their shell's .rc file to automatically
reset window titles after each shell command.
@addaleax addaleax requested a review from a team as a code owner December 1, 2025 14:05
Copilot AI review requested due to automatic review settings December 1, 2025 14:05
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR clears the terminal window title when mongosh exits to prevent the mongosh-set title from persisting after the application closes. The change adds a call to setTerminalWindowTitle('') in the exit handler to reset the title on a best-effort basis.

  • Adds terminal window title clearing on exit

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@addaleax addaleax merged commit 804748d into main Dec 1, 2025
153 of 156 checks passed
@addaleax addaleax deleted the 1233-dev branch December 1, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants