Skip to content

fix(cli-repl): Fix depcheck with a more permissive workaround for the searchParams type #2219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix(cli-repl): Fix depcheck with a more permissive workaround for the searchParams type #2219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions packages/cli-repl/src/cli-repl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1017,12 +1017,11 @@ export class CliRepl implements MongoshIOProvider {
}

async isTlsKeyFilePasswordMissingURI(
searchParams: ReturnType<
typeof ConnectionString.prototype.typedSearchParams<DevtoolsConnectOptions>
>
searchParams: unknown
): Promise<boolean> {
const tlsCertificateKeyFile = searchParams.get('tlsCertificateKeyFile');
const tlsCertificateKeyFilePassword = searchParams.get(
const searchMap = searchParams as Map<keyof DevtoolsConnectOptions, string>;
const tlsCertificateKeyFile = searchMap.get('tlsCertificateKeyFile');
const tlsCertificateKeyFilePassword = searchMap.get(
Copy link
Collaborator

@addaleax addaleax Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could have used a bit more description of what it is fixing, plus maybe a TODO comment to revert it at some point (if that is possible) since we're losing type safety here?

Copy link
Contributor Author

@gagik gagik Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I actually wonder if the depCheck bump would allow us to revert this now; will check

'tlsCertificateKeyFilePassword'
);

Expand Down
Loading