chore: rename vectorSearch feature flag to search #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames the vectorSearch feature flag to search throughout the codebase to better reflect that it guards both vector search and general search-related functionality in MongoDB Atlas.
Key Changes
- Renamed the preview feature flag from
vectorSearchtosearchin code, tests, and documentation - Updated all references to the flag in tool implementations, configuration validation, and user-facing messages
- Added a new
test:localnpm script for running tests without Atlas dependencies
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/common/schemas.ts | Updated the preview feature value from "vectorSearch" to "search" |
| src/common/config/createUserConfig.ts | Renamed variable and updated warning messages to reference "search" instead of "vectorSearch" |
| src/common/search/embeddingsProvider.ts | Updated feature flag check in VoyageEmbeddingsProvider configuration |
| src/tools/mongodb/create/createIndex.ts | Updated feature flag checks and tool description references |
| src/tools/mongodb/create/insertMany.ts | Updated feature flag checks for embedding parameters |
| src/tools/mongodb/delete/dropIndex.ts | Updated feature flag check for index type validation |
| src/tools/mongodb/metadata/collectionIndexes.ts | Updated feature flag check for search index support |
| src/tools/mongodb/metadata/explain.ts | Updated feature flag check in aggregate arguments schema |
| src/tools/mongodb/read/aggregate.ts | Updated feature flag check in aggregate arguments schema |
| src/tools/mongodb/read/export.ts | Updated feature flag check in aggregate arguments schema |
| tests/unit/common/config.test.ts | Updated test cases to use "search" flag and verify new warning messages |
| tests/integration/tools/mongodb/create/createIndex.test.ts | Updated test configurations to use "search" feature flag |
| tests/integration/tools/mongodb/create/insertMany.test.ts | Updated test configurations to use "search" feature flag |
| tests/integration/tools/mongodb/delete/dropIndex.test.ts | Updated test configurations to use "search" feature flag |
| tests/integration/tools/mongodb/metadata/collectionIndexes.test.ts | Updated test configuration to use "search" feature flag |
| tests/integration/tools/mongodb/read/aggregate.test.ts | Updated test configuration to use "search" feature flag |
| README.md | Updated documentation to reference "search" flag and clarified it covers both Atlas Search and Vector Search |
| package.json | Added new test:local script for running tests without Atlas dependencies |
Collaborator
Pull Request Test Coverage Report for Build 19701495156Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
himanshusinghs
approved these changes
Nov 25, 2025
Collaborator
himanshusinghs
left a comment
himanshusinghs
left a comment
There was a problem hiding this comment.
I think a few tests needs to be fixed to pass the correct preview features as well. The rest of the changes looks good.
Collaborator
|
It's kinda weird that all the tests are passing. The feature flag in a few are not correctly passed. |
Collaborator
|
Here are the ones I could find: |
gagik
approved these changes
Nov 25, 2025
Collaborator
|
Just one more 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Renames the feature flag to search considering it also guards a few search-related experiences.