chore: bump mcp sdk #744
chore: bump mcp sdk #744
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the @modelcontextprotocol/sdk package from version ^1.17.4 to ^1.22.0 and addresses breaking changes introduced by the new SDK version. The main changes involve updates to tool annotations, error handling, and server configuration.
Key Changes
- Modified tool annotations to remove the redundant
descriptionfield from annotations since it's now only present at the tool level - Updated error handling in tests to check for error responses instead of catching exceptions
- Moved server instructions from
registerCapabilitiesto theMcpServerconstructor
Reviewed Changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updated @modelcontextprotocol/sdk to ^1.22.0 and mongodb to ^6.21.0 |
| src/tools/tool.ts | Removed description field from tool annotations |
| src/server.ts | Removed instructions from capabilities registration |
| src/transports/base.ts | Added instructions to McpServer constructor and created helper method |
| tests/integration/helpers.ts | Updated test helpers to accept operation type parameter and modified error handling approach |
| tests/integration/tools/**/*.test.ts | Added operation type parameter to all validateToolMetadata calls |
| protected get annotations(): ToolAnnotations { | ||
| const annotations: ToolAnnotations = { | ||
| title: this.name, | ||
| description: this.description, |
There was a problem hiding this comment.
AFAICT the description should never have been part of the annotations and now is rejected as it's an unknown key.
| this.mcpServer.server.registerCapabilities({ | ||
| logging: {}, | ||
| resources: { listChanged: true, subscribe: true }, | ||
| instructions: this.getInstructions(), |
There was a problem hiding this comment.
This was similarly never part of capabilities and was previously ignored. Now it's correctly rejected. I moved it to base.ts where it should live.
| expect(tool.annotations.title).toBe(name); | ||
| expect(tool.annotations.description).toBe(description); | ||
|
|
||
| switch (tool.operationType) { |
There was a problem hiding this comment.
This never worked - operationType would always be undefined, resulting in this switch getting largely ignored. This now fails correctly, which forced me to propagate the expectation across multiple tests, which is the reason for most of the changes here.
Pull Request Test Coverage Report for Build 19552615840Details
💛 - Coveralls |
Proposed changes
This bumps the MCP SDK npm package and fixes some breaking changes.