-
Notifications
You must be signed in to change notification settings - Fork 9
feat(mongodb-runner): make suitable for drivers team use DRIVERS-3335 #598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 14 commits
a317cce
b6beb60
bde597f
462f151
28a10e2
5e383ec
e475696
625c540
47de6fd
4c756a1
23bb0d3
d159b3d
fea6ceb
74b8c93
008bfdf
04249ed
4746fa0
acfe911
401163c
42cc373
d919fe9
41b1b32
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -74,7 +74,10 @@ import type { MongoClientOptions } from 'mongodb'; | |
| type: 'string', | ||
| describe: 'Configure OIDC authentication on the server', | ||
| }) | ||
| .config() | ||
| .env('MONGODB_RUNNER') | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since "shards" can be an object now, I think There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Note: I'm testing this using the cli instead of programmatically, to align more closely with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here's that new PR: mongodb-labs/drivers-evergreen-tools#706 |
||
| .option('debug', { type: 'boolean', describe: 'Enable debug output' }) | ||
| .option('verbose', { type: 'boolean', describe: 'Enable verbose output' }) | ||
| .command('start', 'Start a MongoDB instance') | ||
| .command('stop', 'Stop a MongoDB instance') | ||
| .command('prune', 'Clean up metadata for any dead MongoDB instances') | ||
|
|
@@ -86,9 +89,12 @@ import type { MongoClientOptions } from 'mongodb'; | |
| .demandCommand(1, 'A command needs to be provided') | ||
| .help().argv; | ||
| const [command, ...args] = argv._.map(String); | ||
| if (argv.debug) { | ||
| if (argv.debug || argv.verbose) { | ||
| createDebug.enable('mongodb-runner'); | ||
| } | ||
| if (argv.verbose) { | ||
| createDebug.enable('mongodb-runner:*'); | ||
| } | ||
|
|
||
| if (argv.oidc && process.platform !== 'linux') { | ||
| console.warn( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haha I can't believe I missed this option. 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that it passes options through that aren't defined in the cli options, so we don't need to add all of the new options to the cli.