-
Notifications
You must be signed in to change notification settings - Fork 425
feat: Support multiple subtitles per segment and extend TTS voices #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Refactor subtitle generation to handle text chunks and improve translation process.
Summary of ChangesHello @xiaoxianhjy, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces significant enhancements to the video generation process by enabling the display of multiple, chunked subtitles within a single video segment, thereby resolving issues with excessively long text. Concurrently, it greatly expands the available Text-to-Speech voice options, offering a richer selection of Chinese and English voices for content creation. These updates improve both the visual presentation and auditory diversity of generated videos. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for multiple subtitles per segment and extends the available TTS voices. The changes for adding more voices are straightforward configuration updates. The implementation for multiple subtitles involves a new, complex text-splitting function and modifications to the video composition logic. While the features are valuable, I've identified opportunities to improve code robustness, maintainability, and clarity. My review includes suggestions to fix a potential bug in text splitting, simplify complex code, and make file handling more resilient to errors.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Change Summary
Related issue number
Checklist
pre-commit installandpre-commit run --all-filesbefore git commit, and passed lint check.