-
Notifications
You must be signed in to change notification settings - Fork 625
Add ability to download srt and txt #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @xcv58, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience by introducing the ability to download the generated transcription results. Users can now easily obtain both the plain text recognition output and the SRT subtitle file directly from the application's interface, streamlining the workflow for accessing and utilizing the processed content. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces a new save_text_to_file utility function to automatically save recognition results (text and SRT) with timestamps, either to a specified output directory or a temporary location, and integrates this into the Gradio UI to provide downloadable links for these files. A review comment suggests improving the save_text_to_file function by creating the output_dir if it's specified but doesn't exist, rather than silently falling back to a temporary directory, to ensure more robust behavior consistent with other parts of the codebase.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Add ability to download srt and txt, screenshots:
Sample files:
result_20251212_233406.txt
result_20251212_233406.srt.txt (the
.txtis manually added since GitHub doesn't allow.srtfile)