Skip to content

Conversation

@rgrunberg
Copy link

@rgrunberg rgrunberg commented Oct 25, 2021

The retention heatmap cell text is difficult to read on a dark background. This PR:

  • Pulls getTextColor out of the conditional formatting functions and make it a general shared function
  • Colors the text of the retention heatmap cells according to the background shade

Before:
image

After:
image

@rgrunberg
Copy link
Author

Hi @Jonrosario5 are you able to approve PRs? Or do you have advice on getting PRs merged in this repo? Thanks!

@Jonrosario5
Copy link
Contributor

Hi @rgrunberg I don't have access to approve the PR because it is protected and only specific admins can merge into this Repo. But I'll notify our team and will have someone review the merge and approve it.

@rgrunberg
Copy link
Author

@Jonrosario5 thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants