fix data-focus target assignment #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the data-focus atribute
Currently the
data-focusattribute does not work as described in your documentation.The method, which assigns the corresponding target in the data-focus attribute is not correct. Therefore I fixed it in this PR.
Adding currentTarget var
Currently if an event gets provided to the moveFocusBox function the fallback was
document.activeElement.This does not respect the ability of applying the focusBox to another element than the one which is currently active.
Therefore I added the
currentTargetvariable which gets assigned after thedata-focus/data-focus-label/data-focus-ignoreexceptions in the onFocusHandler function. The variable will then be used in the moveFocusBox as a new fallback.This will ensure that always the correct element will be focused when the moveFocusBox function is being called.