Search more paths when JAVA_HOME exists on Linux #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, if JDK is installed by sdkman, it doesn't have jre directory, and libjvm.so is located in $JAVA_HOME/lib/server/libjvm.so. So this CL just leverages existing approach to search multiple potential paths for libjvm.so when JAVA_HOME doesn't exist on Linux or macOS platforms. Test it locally with ./test and all tests passed without core dump. Signed-off-by: utzcoz <utzcoz@outlook.com>
Signed-off-by: utzcoz <utzcoz@outlook.com>
Author
|
Looks like action/setup-java exports JAVA_HOME, and JDK21 uses different path for libjvm.so on Linux. Maybe modifying the GitHub Actions to tests with different JDKs, for example JDK8 and JDK21 can help to catch this issue for future changes. |
Author
|
Friendly ping @rpavlik for reviewing. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, if JDK is installed by sdkman, it doesn't have jre directory, and libjvm.so is located in $JAVA_HOME/lib/server/libjvm.so.
So this CL just leverages existing approach to search multiple potential paths for libjvm.so when JAVA_HOME doesn't exist on Linux or macOS platforms.
Test it locally with ./test and all tests passed without core dump with the JDK 21 installed by sdkman locally on Ubuntu 24.04.