Added fix for Hasura using websockets in async_base_client #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hasura sometimes sends ping before connection_ack
rafalp
suggested changes
Mar 25, 2024
Contributor
rafalp
left a comment
rafalp
left a comment
There was a problem hiding this comment.
LGTM but is missing tests.
| websocket, | ||
| expected_type=GraphQLTransportWSMessageType.CONNECTION_ACK, | ||
| ) | ||
| # if ping is received, send pong and continue to wait for connection_ack |
Contributor
There was a problem hiding this comment.
Please make comment explain that some servers can send ping before connection_ack.
|
need this PR merged too... |
Author
|
I am not good enough with Python to write the tests. Could someone else please help checking my solution and writing the tests? |
DamianCzajkowski
force-pushed
the
main
branch
from
e74ba77 to
e8458ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hasura sometimes sends ping before connection_ack
https://wundergraph.com/blog/quirks_of_graphql_subscriptions_sse_websockets_hasura_apollo_federation_supergraph