BackupTrait::getDriverName() has been removed

Author: mirko-pagliai

CHANGELOG.md

@@ -1,7 +1,7 @@
 # 2.x branch
 ## 2.7 branch
 ### 2.7.0
-* `BackupTrait::getTarget()` has been removed.
+* `BackupTrait::getTarget()` and `BackupTrait::getDriverName()` have been removed.
 
 ## 2.6 branch
 ### 2.6.6

src/BackupTrait.php

@@ -95,12 +95,11 @@ public function getConnection($name = null)
      * @since 2.0.0
      * @throws \InvalidArgumentException
      * @uses getConnection()
-     * @uses getDriverName()
      */
     public function getDriver(ConnectionInterface $connection = null)
     {
         $connection = $connection ?: $this->getConnection();
-        $className = $this->getDriverName($connection);
+        $className = get_class_short_name(get_class($connection->getDriver()));
         $driver = App::classname(sprintf('%s.%s', 'DatabaseBackup', $className), 'Driver');
         is_true_or_fail(
             $driver,
@@ -111,20 +110,6 @@ public function getDriver(ConnectionInterface $connection = null)
         return new $driver($connection);
     }
 
-    /**
-     * Gets the driver name, according to the database engine
-     * @param \Cake\Datasource\ConnectionInterface|null $connection A connection object
-     * @return string The driver name
-     * @since 2.6.2
-     * @uses getConnection()
-     */
-    public function getDriverName(ConnectionInterface $connection = null)
-    {
-        $connection = $connection ?: $this->getConnection();
-
-        return get_class_short_name(get_class($connection->getDriver()));
-    }
-
     /**
      * Returns the extension from a filename
      * @param string $filename Filename

src/Console/Command.php

@@ -36,7 +36,7 @@ public function execute(Arguments $args, ConsoleIo $io)
         $config = $this->getConnection()->config();
 
         $io->out(__d('database_backup', 'Connection: {0}', $config['name']));
-        $io->out(__d('database_backup', 'Driver: {0}', $this->getDriverName($this->getConnection())));
+        $io->out(__d('database_backup', 'Driver: {0}', get_class_short_name(get_class($this->getConnection()->getDriver()))));
         $io->hr();
 
         return null;

tests/TestCase/BackupTraitTest.php

@@ -131,17 +131,6 @@ public function testGetDriver()
         $this->getDriver($connection);
     }
 
-    /**
-     * Test for `getDriverName()` method
-     * @test
-     */
-    public function testGetDriverName()
-    {
-        foreach ([ConnectionManager::get('test'), null] as $driver) {
-            $this->assertEquals('Mysql', $this->getDriverName($driver));
-        }
-    }
-
     /**
      * Test for `getExtension()` method
      * @test