BackupTrait::getTarget() has been removed

Author: mirko-pagliai

CHANGELOG.md

@@ -1,4 +1,8 @@
 # 2.x branch
+## 2.7 branch
+### 2.7.0
+* `BackupTrait::getTarget()` has been removed.
+
 ## 2.6 branch
 ### 2.6.6
 * APIs are now generated by `phpDocumentor` and no longer by` apigen`.

src/BackupTrait.php

@@ -36,11 +36,14 @@ trait BackupTrait
      * Returns an absolute path
      * @param string $path Relative or absolute path
      * @return string
-     * @uses getTarget()
      */
     public function getAbsolutePath($path)
     {
-        return (new Filesystem())->isAbsolutePath($path) ? $path : add_slash_term($this->getTarget()) . $path;
+        if (!(new Filesystem())->isAbsolutePath($path)) {
+            $path = add_slash_term(Configure::read('DatabaseBackup.target')) . $path;
+        }
+
+        return $path;
     }
 
     /**
@@ -136,15 +139,6 @@ public function getExtension($filename)
         return in_array($extension, $this->getValidExtensions()) ? $extension : null;
     }
 
-    /**
-     * Returns the target path
-     * @return string
-     */
-    public function getTarget()
-    {
-        return Configure::read('DatabaseBackup.target');
-    }
-
     /**
      * Returns all valid compressions
      * @return array

src/Utility/BackupManager.php

@@ -68,7 +68,7 @@ public function deleteAll()
      */
     public function index()
     {
-        $finder = (new Finder())->files()->name('/\.sql(\.(gz|bz2))?$/')->in($this->getTarget());
+        $finder = (new Finder())->files()->name('/\.sql(\.(gz|bz2))?$/')->in(Configure::read('DatabaseBackup.target'));
 
         return collection($finder)->map(function (SplFileInfo $file) {
             return new Entity([

tests/TestCase/Utility/BackupExportTest.php

@@ -117,7 +117,7 @@ public function testFilename()
     {
         $this->BackupExport->filename('backup.sql.bz2');
         $this->assertEquals(
-            add_slash_term($this->BackupExport->getTarget()) . 'backup.sql.bz2',
+            add_slash_term(Configure::read('DatabaseBackup.target')) . 'backup.sql.bz2',
             $this->getProperty($this->BackupExport, 'filename')
         );
         $this->assertEquals('bzip2', $this->getProperty($this->BackupExport, 'compression'));

version

@@ -1 +1 @@
-2.6.6
+2.7.0