Returning resource type for relationship members and adding more information to relationship #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FehintolaObafemi
force-pushed
the
FehintolaObafemi/RelationshipMembers
branch
from
fe0c87d to
90d9eb0
Compare
FehintolaObafemi
force-pushed
the
FehintolaObafemi/RelationshipMembers
branch
from
90d9eb0 to
9296145
Compare
eketo-msft
requested changes
Dec 4, 2025
generated/microsoftgraph/microsoft.graph/v1.1/0.1.1-preview/index.json
Outdated
Show resolved
Hide resolved
| "id": { "type": "string", "description": "The unique identifier..." }, | ||
| "type": { "type": "string", "readOnly": true, "description": "The type of the relationship member..." }, | ||
| "displayName": { "type": "string", "readOnly": true, "description": "The display name..." }, | ||
| "userPrincipalName": { "type": "string", "readOnly": true, "description": "The user principal name..." }, |
Contributor
There was a problem hiding this comment.
Confirm the fields which are empty/unrelated to type are not returned.
For example, SP will be appId and not userPrincipalName... User is UPN, not appId... etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements enhanced relationship member types for Microsoft Graph Bicep Types, introducing richer object structures for relationship members and adding support for the new
v1.1API version. The changes provide advanced filtering, referencing, and type-based operations while maintaining backward compatibility with existing v1.0 implementations. The update includes new schema definitions, version detection logic, and comprehensive test coverage.Key changes grouped by theme:
Enhanced Relationship Member Types
microsoft.graph.relationshipMember) that includes fields likeid,type,displayName,userPrincipalName,appId, anduniqueName, enabling type-based filtering and richer object referencing in enhanced API versions.swaggerWriter.tsand type index building ingenerate.tsto conditionally use the enhanced relationship member structure forbeta/1.1.0-previewandv1.1/0.1.1-previewversions, while maintaining string arrays for legacy versions.API Versioning and Configuration
v1.1API version in the codebase, including updates to enums (ApiVersion), configuration files (extensionConfig.json), generation logic (extensionConfigForGeneration), and file path handling.Documentation and Validation
RELATIONSHIP_MEMBERS_PROPOSAL.md) detailing the motivation, schema changes, usage scenarios, migration paths, and validation results for the enhanced relationship member types.Test and Metadata Updates
msgraph-metadatasubmodule to reference the latest commit.These changes enable advanced Microsoft Graph Bicep template scenarios with improved flexibility and maintainability, while ensuring existing implementations remain unaffected.
#235
Microsoft Reviewers: Open in CodeFlow