-
Notifications
You must be signed in to change notification settings - Fork 11
Added bicepconfig, main, metadata, and README #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
quickstart-templates/remove-serviceprincipal-credentials/metadata.json
Outdated
Show resolved
Hide resolved
dkershaw10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@linkhp Thank you for your contribution here!
|
|
||
| > **Note**: Minimum Bicep version required to deploy this quickstart template is [v0.32.4](https://github.com/Azure/bicep/releases/tag/v0.32.4). | ||
|
|
||
| This template allows you to remove credentials on a service principal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a bit more context in the README? Maybe describing the scenario with more details, like when would someone want to remove credentials on a service principal, what does it mean to remove them, how should service principals authenticate themselves, etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed via recent commits.
Co-authored-by: Dan Kershaw [MSFT] <dkershaw10@users.noreply.github.com>
Microsoft Reviewers: Open in CodeFlow