Defer alpha channel setting to Color.Format.CSS functions
#284946
+123
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #256853 where fully opaque colors (alpha=1) were incorrectly appending an alpha suffix to hex color formats. The fix simplifies the code by delegating alpha channel handling entirely to the Color.Format.CSS functions, which already have the correct logic built-in.
- Simplified color formatting by removing manual alpha channel checks
- Added comprehensive unit tests covering opaque, transparent, and semi-transparent colors
- Included regression tests for both the current issue (#256853) and the related issue (#243746)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/vs/editor/contrib/colorPicker/browser/defaultDocumentColorProvider.ts |
Simplified color formatting logic by delegating to Color.Format.CSS functions which handle alpha channel internally |
src/vs/editor/contrib/colorPicker/test/browser/defaultDocumentColorProvider.test.ts |
Added comprehensive test suite covering opaque, transparent, and semi-transparent colors with regression tests |
src/vs/editor/contrib/colorPicker/browser/defaultDocumentColorProvider.ts
Outdated
Show resolved
Hide resolved
…Provider.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit 19de81f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #256853
Added unit-tests, including tests for the related issues.
The main change is to let
Color.Format.CSSfunctions handle the alpha channel which they seem to be doing just fine (including HEX/HEXA formats).