Fix shadow DOM mouseleave detection in editor #284890
Open
+5
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
When the editor is hosted inside a Shadow DOM, mouse moves could make the global mouseleave recovery think the pointer left the editor as soon as the event target falls outside the light-DOM container. This erroneously fires mouseLeave, which can break hover/selection behavior even though the pointer is still visually over the editor.
Fix:
In the global mousemove recovery path, when the event target is outside the light-DOM container, we now query shadowRoot.elementsFromPoint and ensure none of the hit elements belong to the editor before emitting mouseLeave. This keeps the monitor active but only triggers leave when the pointer truly exits the editor, including Shadow DOM embeddings.
Fixes monaco issue: microsoft/monaco-editor#3409
Based on the changes requested in #166240