Treat column number in Go To Line as visible column #284668
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the "Go To Line" feature to treat column numbers as visible columns rather than character positions, which correctly handles tabs and other multi-column characters. The PR also removes the ARIA label, as mentioned in the description, with plans to replace it with a command for current location.
Key Changes
- Column numbers in "Go To Line" input are now interpreted as visible columns, accounting for tabs and other multi-column characters
- The
CursorColumnsutility is used to convert between visible columns (what users see) and actual column positions (character offsets) - ARIA label removed from the quick pick interface
- Comprehensive tests added for tab handling with positive and negative column offsets
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/editor/contrib/quickAccess/browser/gotoLineQuickAccess.ts |
Added visible column calculations using CursorColumns utility for both offset mode and line:column mode; removed ARIA label assignment; imports CursorColumns |
src/vs/editor/contrib/quickAccess/test/browser/gotoLineQuickAccess.test.ts |
Added runTabTest helper function and comprehensive test suite for tab handling with 26 test cases covering various column positions and negative offsets |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #280540
Also removed ARIA label since it wasn't read by all readers and the plan is to add a command for current location.