Add editorBracketMatch-foreground color setting #284531
Open
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new optional color setting editorBracketMatch.foreground that allows users to customize the foreground (text) color of matching brackets. The implementation uses a unique inlineClassName (bracket-match-inline) to apply the color styling, which avoids layout jumps that occurred in a previous attempt. The foreground color is set to override bracket pair colorization when defined.
Key Changes
- New color setting
editorBracketMatch.foregrounddefaults to null (optional) - Uses
inlineClassNamepattern to apply color without affecting layout - CSS rule with
!importantensures bracket match color overrides bracket pair colorization
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/vs/editor/common/core/editorColorRegistry.ts |
Registers the new editorBracketMatch.foreground color with null default |
src/vs/editor/contrib/bracketMatching/browser/bracketMatching.ts |
Adds inlineClassName to decoration options and implements theming participant to apply the foreground color with appropriate specificity |
build/lib/stylelint/vscode-known-variables.json |
Adds CSS variable --vscode-editorBracketMatch-foreground to known variables list |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85775
Added new color editorBracketMatch-foreground (defaults to null) and use it for matching brackets foreground color.
Round 2: using new and unique inlineClassName to avoid pushing outlining into the span (which was causing text jumping with previous attempt).
We can also probably close #284437