-
Notifications
You must be signed in to change notification settings - Fork 692
Close outdated multidiff editors when PR is reopened #8256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
alexr00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot revert all the whitespace/formating only changes. I can't read the diff.
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
alexr00
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
Updated in commit c453eae to use the TabInputTextMultiDiff API. Removed the workaround with |
Plan: Close multidiff editors when outdated ✅
Understanding the Problem
Implementation Plan
vscode.commands.executeCommand('vscode.changes', ...)_closeOutdatedMultiDiffEditorsmethod using TabInputTextMultiDiff APIinstanceof vscode.TabInputTextMultiDiff_closeOutdatedMultiDiffEditorsin_upgradePullRequestEditorsTechnical Approach
Uses the
TabInputTextMultiDiffAPI (added via proposed API in commit 793ea80):instanceof vscode.TabInputTextMultiDiffto identify multidiff tabs_upgradePullRequestEditorsis calledImplementation Details
_closeOutdatedMultiDiffEditors()method toReviewManagerclassTabInputTextMultiDiffAPI for type checking_upgradePullRequestEditors()Security Summary
CodeQL security analysis completed successfully with 0 vulnerabilities found.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.