-
Notifications
You must be signed in to change notification settings - Fork 747
fix TS6053 missing file diagnostics to match tsc (#2081) #2096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
TranNhatHan
wants to merge
32
commits into
microsoft:main
from
TranNhatHan:fix-missing-file-diagnostics
Closed
Changes from 2 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
371cacd
fix (unfinished) TS6053 missing file diagnostics to match tsc (#2081)
3b00267
Merge branch 'main' into fix-missing-file-diagnostics
TranNhatHan 67db554
Delete TestMissingReferenceFile test case
TranNhatHan 5de90ce
Merge branch 'microsoft:main' into fix-missing-file-diagnostics
TranNhatHan 5b87cc2
completely fix the missing error file not found bug
0b3f881
failed incremental test in scenario "when global file is added, the s…
b44a247
fix: attach missing-file diagnostics to the correct source file
b615125
fix: resolve golangci-lint errors
5bad47f
Merge branch 'microsoft:main' into fix-missing-file-diagnostics
TranNhatHan 873b273
Merge branch 'main' into fix-missing-file-diagnostics
TranNhatHan 77d30af
Merge branch 'main' into fix-missing-file-diagnostics
TranNhatHan ad50113
update code per maintainer suggestions
ea23f59
Merge branch 'main' into fix-missing-file-diagnostics
TranNhatHan 0ed3489
reset the .golangci.yml as default
f46ccc9
reset the .golangci.yml as default
02696be
Merge branch 'main' into fix-missing-file-diagnostics
TranNhatHan 87bd8d6
accept new baseline
aad5fc2
Revert "accept new baseline"
eadc7bf
update new baseline
1999a76
Revert "update new baseline"
1dddca1
failed tests
f4eddf6
failed incremental test
3ebb753
update new baseline
a8a4b3c
fix
5af31f1
Revert "failed incremental test"
c29d729
Revert "update new baseline"
aa2b4cf
fix
363bde5
keep fixing
4edbc11
Merge pull request #1 from TranNhatHan/fix-bug
TranNhatHan b0adcfe
Merge branch 'main' into fix-missing-file-diagnostics
TranNhatHan 7e18c1f
raise error but change other behaviours
a6958e0
Merge branch 'fix-missing-file-diagnostics' of https://github.com/Tra…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for this; if you fixed the bug, the
declarationEmitIndexTypeNotFoundtest should have been updated when you ran the tests.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have just fixed the bug, should i open a new pull request or just commit on this request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just push to this one, please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still an issue; the PR is not fixing the test I mentioned above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the last commit, I only made changes to loaderfile.go and program.go. I had previously added a new test (TestMissingReferenceFile), but it has been removed following the your guidance. Please let me know if I have misunderstood your point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the fix in this PR worked, then the test case Ryan was showing,
declarationEmitIndexTypeNotFound, would fail and ask you to update the baselines, and likely other tests. The fact that this PR contains code but no test baseline changes means the fix is not working.Are you testing this some other way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, got it! so if the bug is fixed, the tests are expected to fail and I need to update the baseline, right?
Previously, I ran a test locally for debugging and compiled an erroneous .ts file to check whether the error matched what tsc would produce. After that, I ran go test, which failed. I then code again to pass the test but forgot to manually verify it again, so I just realized that my last commit didn’t actually solve the issue.
Now I have fixed the bug again and I’ve updated the baseline, but it resulted in 64 changes, and I’m not sure how to verify whether the updated baseline is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like an improvement with some regressions; if you view https://github.com/microsoft/typescript-go/pull/2096/files?file-filters%5B%5D=.go&file-filters%5B%5D=.diff (filtered to diffs), the goal would be to eliminate those by improving the fix.