Skip to content

fix: make ResponseMessage.Result omitzero #1533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 8, 2025
Merged

fix: make ResponseMessage.Result omitzero #1533

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
515a0fa
fix: make ResponseMessage.Result omitzero
skewb1k Aug 7, 2025
8e88d5b
Use explicit null for LSP responses
jakebailey Aug 8, 2025
20959a2
Do TokenRead
jakebailey Aug 8, 2025
f53a106
Make consistent with other null checks
jakebailey Aug 8, 2025
1bdb992
Merge branch 'main' into fix/result-omitzero
skewb1k Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/lsp/lsproto/jsonrpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ func (r *RequestMessage) UnmarshalJSON(data []byte) error {
type ResponseMessage struct {
JSONRPC JSONRPCVersion `json:"jsonrpc"`
ID *ID `json:"id,omitzero"`
Result any `json:"result"`
Result any `json:"result,omitzero"`
Error *ResponseError `json:"error,omitzero"`
}

Expand Down
Loading