Allow multiple FileDataSourceAttribute to be used #431
+8
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xj-ms
requested review from
helenkzhang,
jmaxson-ms,
malavshah11 and
trgibeau
as code owners
Simply updating `FileDataSourceAttribute` will allow plugins to support multiple different file extensions. WPA already has the support for it as WPA always processes `FileDataSourceAttribute` in an `IEnumerable`. Even in this repo we have tests for multiple extensions (`TryGetFileExtensions_FileDataSources_ReturnsExtensions`)
xj-ms
force-pushed
the
user/jing/file-data-source
branch
from
cc446bb to
8a68d97
Compare
Copilot finished reviewing on behalf of
xj-ms
December 1, 2025 23:56
There was a problem hiding this comment.
Pull request overview
This PR enables the use of multiple FileDataSourceAttribute instances on a single processing source class, allowing plugins to support multiple file extensions. The change is minimal—flipping the AllowMultiple parameter from false to true—because the Windows Performance Analyzer (WPA) infrastructure already processes these attributes as an enumerable collection. The PR also includes test updates demonstrating the new capability, along with minor documentation improvements and dependency updates.
Key Changes:
- Modified
FileDataSourceAttributeto allow multiple instances per class (AllowMultiple = true) - Updated test class
MultiDataSourceCdsto demonstrate multiple file extensions using separate attribute instances - Corrected documentation spelling and updated .NET version guidance
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/Microsoft.Performance.SDK/Processing/FileDataSourceAttribute.cs |
Changed AttributeUsage to allow multiple FileDataSourceAttribute instances on a single class |
src/Microsoft.Performance.SDK.Runtime.Tests/ProcessingSourceReferenceTests.cs |
Updated test class to demonstrate multiple file extensions with two separate FileDataSource attributes; removed unused imports |
src/SDK.sln |
Auto-updated Visual Studio version metadata (VS 17→18) |
samples/SimpleDataSource/SampleAddIn.csproj |
Updated SDK package reference from version 1.0.14-rc1 to 1.4.7-preview2 |
samples/SimpleDataSource/README.md |
Fixed typo in documentation path ("documentaiton" → "documentation") |
documentation/Using-the-SDK/Creating-your-plugin.md |
Updated .NET version guidance to reference .NET 8 and clarify WPA compatibility requirements |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
malavshah11
approved these changes
Dec 2, 2025
helenkzhang
reviewed
Dec 2, 2025
helenkzhang
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply removing this will allow plugins to support multiple different file extensions. WPA already has the support for it as WPA always processes
FileDataSourceAttributein anIEnumerable. Even in this repo we have tests for multiple extensions (TryGetFileExtensions_FileDataSources_ReturnsExtensions)