-
Notifications
You must be signed in to change notification settings - Fork 2.9k
refactor(motion-components): improve parameter naming from 'from/to' to 'out/in' #35592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
robertpenner
wants to merge
23
commits into
microsoft:master
Choose a base branch
from
robertpenner:refactor/motion-from-to-out-in
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor(motion-components): improve parameter naming from 'from/to' to 'out/in' #35592
robertpenner
wants to merge
23
commits into
microsoft:master
from
robertpenner:refactor/motion-from-to-out-in
+360
−315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull request demo site: URL |
…Scale, and Slide components
…/inAngle and update related tests
…s/inRadius and update related tests
…update related tests
… "fromY" to "outX" and "outY"
58bd1be to
6f93150
Compare
📊 Bundle size reportUnchanged fixtures
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Problem
fromXandtoX,fromScaleandtoScale.entertransitions, but they became confusing withexittransitions.For example, here's how these parameters work for a 2-way Slide between:
visibleis false (theoutstate)visibleis true (theinstate)The problem arises when we use the one-way motions
<Slide.In>and<Slide.Out>, which are in opposing directions:So the labels could be reversed from user expectations.
Q: Why not use
Slide.Infor both? Why useSlide.Out?A: One practical reason:
Slidehas a default auto-fade, soSlide.Inwill fade in andSlide.Outwill fade out.Solution
To clarify what the parameters do, we're renaming them according to their state:
inorout:fromX/toX→outX/inXfromSize→outSizefromRadius/toRadius→outRadius/inRadiusfromOpacity/toOpacity→outOpacity/inOpacityfromAngle/toAngle→outAngle/inAnglefromScale/toScale→outScale/inScaleNow
outX="20px"clearly means "the X value after exiting", making it unambiguous for bothSlide.InorSlide.Out.Testing