Complete hasLabeledChild utility implementation with source code validation #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uired docs as well.
aubreyquinn
approved these changes
Sep 19, 2025
aubreyquinn
deleted the
users/sidhshar/complete-haslabeledchild-implementation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the implementation of the [hasLabeledChild] utility function that was previously stubbed. The utility is a core component of the rule factory system, enabling comprehensive detection of accessible child content in JSX elements.
🔧 Changes Made
Before
[hasLabeledChild] was a stub function that always returned false
Missing comprehensive child content accessibility validation
Limited support for detecting labeled child elements in buttons, links, and other interactive components
After
Complete implementation with robust child element analysis
Source code validation for aria-labelledby references using ESLint context
Deep traversal of nested child structures using [flattenChildren]
Comprehensive detection of multiple accessible content types
Enhanced rule factory system with proper labeled child validation