Skip to content

Enabling non-standard ports for on-prem using OAuth #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Enabling non-standard ports for on-prem using OAuth #517

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac01b61
Update ConnectionService.cs to allow on-prem ports with OAuth, otherw…
korytiak Jul 11, 2025
a38b8a4
Merge pull request #1 from korytiak/korytiak-on-prem
korytiak Jul 11, 2025
477429f
Update ConnectionService.cs, use Authority instead of DnsSafeHost to …
korytiak Jul 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/GeneralTools/DataverseClient/Client/ConnectionService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1471,7 +1471,7 @@ private async Task<IOrganizationService> DoDirectLoginAsync(bool IsOnPrem = fals

IOrganizationService dvService = null;
Uri OrgWorkingURI = null;
if (!IsOnPrem || _eAuthType == AuthenticationType.OAuth) // Use this even if its onPrem, when auth type == oauth.
if (!IsOnPrem)
{
OrgWorkingURI = new Uri(string.Format(SoapOrgUriFormat, _targetInstanceUriToConnectTo.Scheme, _targetInstanceUriToConnectTo.DnsSafeHost));
Copy link
Member

@tehcrashxor tehcrashxor Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not believe your change does what you think it does.

On line 1476, the Uri.DnsSafeHost property, just like the Uri.Host property, returns only the host portion of the URI, so even if _targetInstanceUriToConnectTo contains your port 444, it would still be stripped out of the URI generated here.

Copy link
Author

@korytiak korytiak Jul 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for explaining the issue with my change. Would updating the .DnsSafeHost to .Authority (which would preserve the port) work as a potential workaround to allow the on-prem usage, or do you see any issue with that? Base on your feeling about this, please reject/accept the PR. Thank you again for your time and correction either way!

}
Expand Down