Skip to content

Conversation

@Josmithr
Copy link
Contributor

@Josmithr Josmithr commented Nov 25, 2025

The RegEx used to implement this rule was overly permissive and yielded lots of false positives. This PR updates the rule to leverage the TSDoc parser directly to extract block tags/comments and evaluate them explicitly.

Unfortunately, this makes it harder to implement auto-fix behavior, so that has been removed.

AB#50920

@Josmithr Josmithr requested a review from a team November 25, 2025 19:22
@github-actions github-actions bot added area: build Build related issues base: main PRs targeted against main branch labels Nov 25, 2025
@Josmithr Josmithr requested review from a team and alexvy86 November 25, 2025 21:52
@Josmithr Josmithr merged commit 3bb132c into microsoft:main Nov 25, 2025
27 checks passed
@Josmithr Josmithr deleted the eslint-plugin-fluid/fix-no-hyphen-rule branch November 25, 2025 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: build Build related issues base: main PRs targeted against main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants