General features #1
Conversation
… and dependency management; enhance README.md with installation instructions and system requirements
…customizing dataset locations
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| install-datasets: ## Download TU datasets (any torch_geometric TUDataset name) into data/<dataset> | ||
| $(RUN_PY) scripts/install_datasets.py --datasets $(DATASETS) --download-root $(TUD_ROOT) --target-root $(DATA_ROOT) |
There was a problem hiding this comment.
The new install-datasets target calls $(RUN_PY) scripts/install_datasets.py, but there is no scripts/install_datasets.py anywhere in the repository (checked with find . -name install_datasets.py). Running make install-datasets as documented will therefore fail immediately with python: can't open file 'scripts/install_datasets.py', leaving the advertised dataset download workflow unusable.
Useful? React with 👍 / 👎.
| statsmodels = "0.14.1" | ||
| torch = "2.4.1" | ||
| torch-geometric = "2.6.1" |
There was a problem hiding this comment.
The new Poetry dependency list pins torch and torch-geometric but does not include the compiled extensions (torch-scatter, torch-sparse, torch-cluster, torch-spline-conv) that PyG layers such as GCNConv (used in SimGNN/src/simgnn.py) import. torch-geometric does not install these extras automatically, so following the README instructions (poetry install → make simgnn-train) will hit ImportError: No module named 'torch_sparse' before training starts. These extensions need to be declared alongside torch-geometric for the new Poetry setup to work.
Useful? React with 👍 / 👎.
No description provided.