Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
90 commits
Select commit Hold shift + click to select a range
f832859
Move download logic to a service object
michaelbaudino Jun 15, 2016
79a4050
Small refactors and renamings in Addic7ed::Episode
michaelbaudino Jun 15, 2016
4198f2a
Rename Addic7edVersionNormalizer and Addic7edCommentNormalizer to Ver…
michaelbaudino Jun 19, 2016
8fed841
Refactor the parser into 2 service objects
michaelbaudino Jun 19, 2016
3cef498
Refactor how Episode initializes and holds subtitles
michaelbaudino Jun 19, 2016
62f0c98
Minor: update refactor TODO list
michaelbaudino Jun 19, 2016
d51a0c1
Rename all service objects to start with a verb
michaelbaudino Jun 19, 2016
1febbd6
Extract services class method to a module
michaelbaudino Jun 19, 2016
b7f2d71
Move models to a subdirectory
michaelbaudino Jun 19, 2016
eb1a705
Move models *specs* to a subdirectory (forgotten files from last comm…
michaelbaudino Jun 19, 2016
5dd58e1
Refactor `ShowList` into 2 service objects (a service that downloads …
michaelbaudino Jun 19, 2016
8097d68
Refactor URLEncodeShowName to be more readable
michaelbaudino Jun 19, 2016
5c3bcb2
Require files more smartly
michaelbaudino Jun 19, 2016
72cf33d
Require the gem code in spec_helper rather than in each spec file
michaelbaudino Jun 19, 2016
387f0b9
Add a console executable because it's handy
michaelbaudino Jun 19, 2016
e3c5334
Allow network requests from the console
michaelbaudino Jun 19, 2016
f6fe3ba
Move logic from Episode model to a new Search model to better separat…
michaelbaudino Jul 9, 2016
b299a34
Add Rubocop and comply to it :cop:
michaelbaudino Jul 9, 2016
c84d715
Fix an error with JRuby
michaelbaudino Jul 9, 2016
4ab73fc
Enable Rubocop for CodeClimate
michaelbaudino Jul 9, 2016
843bab9
Use config generated by CodeClimate
michaelbaudino Jul 9, 2016
e40b9f5
Enable Brakeman engine for Codeship and disable Fixme engine
michaelbaudino Jul 9, 2016
2deebfe
Don't use single-line Rubocop disables
michaelbaudino Jul 9, 2016
17c2bab
Move user agents, languages and URLs to a config file
michaelbaudino Jul 9, 2016
25a14ac
Minor one-line refactor
michaelbaudino Jul 9, 2016
57d9c58
Move compatibility and best-subtitle logics to new CheckCompatibility…
michaelbaudino Jul 11, 2016
7188b64
Rename Subtitle#via to Subtitle#source
michaelbaudino Jul 11, 2016
928edd3
Disable Brakeman on CodeClimate as it's Rails-only :confused:
michaelbaudino Jul 13, 2016
676938b
Add support for normalization of subtitles versions with multiple, da…
michaelbaudino Jul 16, 2016
b5d4836
Fix a typo
michaelbaudino Jul 22, 2016
ce4e1f3
Strip parsed subtitle comment
michaelbaudino Jul 22, 2016
55cbd8e
Add doc for models
michaelbaudino Jul 23, 2016
8214fb8
Change inch badge for v3 branch
michaelbaudino Jul 23, 2016
165f9a6
Check GitHub hook for RubyDoc in TODO list
michaelbaudino Jul 23, 2016
7034d0d
Change Episode protected methods to be private
michaelbaudino Jul 23, 2016
01b521b
Add missing doc for VideoFile initialize parameter
michaelbaudino Jul 23, 2016
9e4e064
Change Travis email notifications setting
michaelbaudino Jul 23, 2016
87587db
Fix Travis email notifications setting
michaelbaudino Jul 23, 2016
3fef232
Bump version to 3.0.0-beta.1 :tada:
michaelbaudino Aug 7, 2016
fb6fd05
Fix internal requiring
michaelbaudino Aug 8, 2016
dab51b6
Bump version to 3.0.0-beta.2
michaelbaudino Aug 8, 2016
96ffed5
Fix config file requiring
michaelbaudino Aug 8, 2016
06e65d2
Bump version to 3.0.0-beta.3
michaelbaudino Aug 8, 2016
24f0dbd
Remove legacy executable script
michaelbaudino Aug 11, 2016
737176a
Bump version to 3.0.0-beta.4
michaelbaudino Aug 11, 2016
ea48696
Fix a doc typo
michaelbaudino Dec 1, 2016
bbceb47
Merge branch 'master' into full-rewrite
michaelbaudino Feb 4, 2017
08db02d
Minor README changes
michaelbaudino Feb 4, 2017
e560f6f
Update Travis setup
michaelbaudino Feb 4, 2017
4a4a101
Update RubyGems before Travis builds
michaelbaudino Feb 4, 2017
46035a2
Specify Rubinius version in Travis config
michaelbaudino Feb 4, 2017
03b099d
Update Rubinius version on Travis
michaelbaudino Feb 4, 2017
6d4276e
Fix README badges
michaelbaudino Feb 4, 2017
7b461d1
Update Rubocop and comply to new rules
michaelbaudino Aug 13, 2017
1541f45
Run rubocop on Travis
michaelbaudino Aug 13, 2017
f40362c
Fix specs
michaelbaudino Aug 13, 2017
db37e68
Remove useless dependency to the json gem
michaelbaudino Aug 13, 2017
f4de55a
Remove useless allowance of WebMock in bin/console
michaelbaudino Aug 13, 2017
350805f
:rocket: Speedup retrieval of the shows list (by avoiding to use an u…
michaelbaudino Aug 13, 2017
6af8863
Stop using Ruby 2.4+ Regexp.matches? for more backward-compatibility
michaelbaudino Aug 13, 2017
0175a89
Stop using <<~EOS heredoc syntax for backward compatibility
michaelbaudino Aug 13, 2017
24b1674
Update Rubinius on Travis
michaelbaudino Aug 13, 2017
23fef08
Just use the latest varsion of Rubinius on Travis, always
michaelbaudino Aug 13, 2017
d28dc57
Try another syntax for rubinius in Travis, because the documented syn…
michaelbaudino Aug 13, 2017
33fbff8
Fix Rubinius syntax for Travis AGAIN (╯°□°)╯︵ ┻━┻)
michaelbaudino Aug 13, 2017
3045492
Minor README update
michaelbaudino Aug 13, 2017
da3f583
Bump version
michaelbaudino Aug 13, 2017
451190f
Add a post-install message to warn that there's no more CLI binary pr…
michaelbaudino Aug 13, 2017
a4c739d
Update README
michaelbaudino Aug 13, 2017
35a97d3
Change SubtitlesCollection to a proper custom Enumerable
michaelbaudino Aug 22, 2017
378e57a
Allow Episode#page_url to return the URL of the page with subtitles f…
michaelbaudino Aug 22, 2017
f76db56
Make filtering methods of SubtitlesCollection return a SubtitlesColle…
michaelbaudino Aug 22, 2017
086870d
Stop overriding select behaviour in SubtitlesCollection
michaelbaudino Aug 23, 2017
a208091
Major refactor of models and parsing
michaelbaudino Dec 29, 2017
51591be
Explicit some dependencies versions
michaelbaudino Dec 29, 2017
59c9de4
Add a few items to the TODO list
michaelbaudino Dec 29, 2017
681bf15
Add support for MRI 2.5
michaelbaudino Jan 15, 2018
cb85386
Fix some Rubocop issues
michaelbaudino Jan 15, 2018
9952328
Add specs placeholders
michaelbaudino Jan 15, 2018
56ccb7c
Release 4.0 beta 7
michaelbaudino Jan 15, 2018
ff53c4e
Fix more Rubocop issues
michaelbaudino Jan 15, 2018
4b95279
More enhancements in README
michaelbaudino Jan 16, 2018
9cbc890
Remove all to_s and inspect overrides
michaelbaudino Jan 16, 2018
435d97a
Add documentation generation instructions
michaelbaudino Jan 16, 2018
4e73a96
Remove obsolete configs related to fetching shows and episodes via AJAX
michaelbaudino Jan 16, 2018
ad54fce
Remove specs forgotten in 9cbc8909069f12582c84c3aa6e1b098a84d73405
michaelbaudino Jan 16, 2018
b523132
Remove DowloadSubtitle service: it belongs to the CLI
michaelbaudino Jan 16, 2018
6087568
Fix a Rubocop complexity issue
michaelbaudino Jan 16, 2018
ef6e2f6
Add mocks for easy local (and eventually offline) development
michaelbaudino Jan 18, 2018
3337a7d
Update TODO.md
michaelbaudino Sep 21, 2018
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .codeclimate.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
---
engines:
duplication:
enabled: true
config:
languages:
- ruby
fixme:
enabled: false
rubocop:
enabled: true
brakeman:
enabled: false
ratings:
paths:
- "**.rb"
exclude_paths:
- spec/
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@ pkg

# Ignore Bundler config
/.bundle
/vendor/bundle/

# Ignore built gems
/*.gem

# YARD doc stuff
/.yardoc
/doc/
2 changes: 2 additions & 0 deletions .rspec
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
--color
--require spec_helper
20 changes: 20 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
AllCops:
TargetRubyVersion: 2.4

Style/StringLiterals:
EnforcedStyle: double_quotes
Enabled: true

Style/StringLiteralsInInterpolation:
EnforcedStyle: double_quotes
Enabled: true

Style/Documentation:
Enabled: false

Metrics/LineLength:
Max: 100

Metrics/BlockLength:
Exclude:
- spec/**/*.rb
14 changes: 12 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,11 +1,21 @@
language: ruby
cache: bundler
dist: trusty
rvm:
- ruby-2.0
- ruby-2.1
- ruby-2.2
- ruby-2.3.0
- rbx
- ruby-2.3
- ruby-2.4
- ruby-2.5
- rbx-3.84
- jruby
before_install:
- gem update --system
- gem update bundler
before_script:
- bundle exec rubocop -D
notifications:
email:
on_success: change
on_failure: change
1 change: 1 addition & 0 deletions .yardopts
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
lib/addic7ed/models/**/*.rb
49 changes: 49 additions & 0 deletions CODE_OF_CONDUCT.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
# Contributor Code of Conduct

As contributors and maintainers of this project, and in the interest of
fostering an open and welcoming community, we pledge to respect all people who
contribute through reporting issues, posting feature requests, updating
documentation, submitting pull requests or patches, and other activities.

We are committed to making participation in this project a harassment-free
experience for everyone, regardless of level of experience, gender, gender
identity and expression, sexual orientation, disability, personal appearance,
body size, race, ethnicity, age, religion, or nationality.

Examples of unacceptable behavior by participants include:

* The use of sexualized language or imagery
* Personal attacks
* Trolling or insulting/derogatory comments
* Public or private harassment
* Publishing other's private information, such as physical or electronic
addresses, without explicit permission
* Other unethical or unprofessional conduct

Project maintainers have the right and responsibility to remove, edit, or
reject comments, commits, code, wiki edits, issues, and other contributions
that are not aligned to this Code of Conduct, or to ban temporarily or
permanently any contributor for other behaviors that they deem inappropriate,
threatening, offensive, or harmful.

By adopting this Code of Conduct, project maintainers commit themselves to
fairly and consistently applying these principles to every aspect of managing
this project. Project maintainers who do not follow or enforce the Code of
Conduct may be permanently removed from the project team.

This code of conduct applies both within project spaces and in public spaces
when an individual is representing the project or its community.

Instances of abusive, harassing, or otherwise unacceptable behavior may be
reported by contacting a project maintainer at michael.baudino@alpine-lab.com. All
complaints will be reviewed and investigated and will result in a response that
is deemed necessary and appropriate to the circumstances. Maintainers are
obligated to maintain confidentiality with regard to the reporter of an
incident.

This Code of Conduct is adapted from the [Contributor Covenant][homepage],
version 1.3.0, available at
[http://contributor-covenant.org/version/1/3/0/][version]

[homepage]: http://contributor-covenant.org
[version]: http://contributor-covenant.org/version/1/3/0/
16 changes: 9 additions & 7 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
source 'https://rubygems.org'
# frozen_string_literal: true

source "https://rubygems.org"
# The gem's dependencies will be specified in addic7ed.gemspec
gemspec

group :test do
gem 'coveralls', require: false
gem "coveralls", require: false
end

platforms :rbx do
gem 'json'
gem 'racc'
gem 'rubysl'
gem 'psych'
gem 'iconv'
gem "iconv", "~> 1.0"
gem "json", "~> 2.1"
gem "psych", "~> 2.2"
gem "racc", "~> 1.4"
gem "rubysl", "~> 2.2"
end
Loading