Skip to content

Communication 2020 08 20 violation fixes #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
memontic-ms wants to merge 2 commits into
base: communication_2020-08-20_stable
Choose a base branch
from
Draft

Communication 2020 08 20 violation fixes #1

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8055ae4
Remove 3 instances of ARM violation R4009
memontic-ms Feb 24, 2021
8e07021
Remove 1 instance of ARM violation R4018
memontic-ms Feb 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...tion/resource-manager/Microsoft.Communication/stable/2020-08-20/CommunicationService.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,6 +670,10 @@
"description": "Name of the operation with format: {provider}/{resource}/{operation}",
"type": "string"
},
"isDataAction": {
Copy link

@allenjzhang allenjzhang Feb 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add new properties to the end of the list? Otherwise the ctor signature may be breaking change.

"description": "Indicates whether the operation is a data action",
"type": "boolean"
},
"display": {
"$ref": "#/definitions/OperationDisplay",
"description": "The object that describes the operation."
Expand Down Expand Up @@ -956,6 +960,9 @@
"$ref": "#/definitions/CommunicationServiceProperties",
"description": "The properties of the service.",
"x-ms-client-flatten": true
},
"systemData": {
"$ref": "../../../../../common-types/resource-management/v2/types.json#/definitions/systemData"
}
}
},
Expand Down