Skip to content

Remove some leftover crude pluralization #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schivmeister merged 2 commits into from
Nov 28, 2025
Merged

Remove some leftover crude pluralization #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24bc0be
fix: remove some leftover crude pluralization
schivmeister Nov 28, 2025
e1533af
fix(test): update tests for pluralization fix
schivmeister Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dqgen/resources/asciidoc_templates/instance.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
{% call mc.render_fetch_results(content, error) %}
{% set compress_uris = simplify_uri_columns_in_tabular(data_frame=content,namespace_inventory=namespaces,error_fail=False) %}
{% endraw %}
=== {{ operation|title }} {{ class_name }}s
{{ "{{" }} mc.pandas_table(content, "{{ operation|title }} {{ class_name }}s") {{ "}}" }}
=== {{ operation|title }} {{ class_name }}
{{ "{{" }} mc.pandas_table(content, "{{ operation|title }} {{ class_name }}") {{ "}}" }}
{% raw %}
{% endcall %}
{% endif %}
Expand Down
4 changes: 2 additions & 2 deletions dqgen/resources/html_templates/instance.jinja2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@
{% call mc.render_fetch_results(content, error) %}
{% set compress_uris = simplify_uri_columns_in_tabular(data_frame=content,namespace_inventory=namespaces,error_fail=False) %}
{% endraw %}
<h2 class="ui header">{{ operation|title }} {{ class_name }}s</h2>
<h2 class="ui header">{{ operation|title }} {{ class_name }}</h2>
<section class="ui basic segment">
<p>The table below lists the {{ operation }} <strong>{{ cls }}</strong>
</p>
<p><strong>Query identifier:</strong> {{ query_file }}</p>
{{ "{{" }} mc.pandas_table(content, "{{ operation|title }} {{ class_name }}s") {{ "}}" }}
{{ "{{" }} mc.pandas_table(content, "{{ operation|title }} {{ class_name }}") {{ "}}" }}
</section>
{% raw %}
{% endcall %}
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_asciidoc_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@


def test_instance_asciidoc_generator(tmp_path):
expected_text = """== Added concepts"""
expected_text = """== Added concept"""
asciidoc_generator = AsciiDocGenerator(cls="skos:Concept", operation="added_instance", class_name="concept",
output_folder_path=str(tmp_path),
template=ASCII_DOC_TEMPLATES.get_template("instance.jinja2"))
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_html_generator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@


def test_instance_html_generator(tmp_path):
expected_text = """<h2 class="ui header">Added concepts</h2>"""
expected_text = """<h2 class="ui header">Added concept</h2>"""
html_generator = HtmlGenerator(cls="skos:Concept", operation="added_instance", class_name="concept",
output_folder_path=str(tmp_path),
template=HTML_TEMPLATES.get_template("instance.jinja2"))
Expand Down