-
Notifications
You must be signed in to change notification settings - Fork 39
Add contributing guidelines and update README #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 5.x
Are you sure you want to change the base?
Conversation
RCheesley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite a few suggestions but they should be quick to fix. Thanks for working on this @adiati98 and no rush!
| - [Git cherry-pick](#git-cherry-pick) | ||
| - [Getting started](#getting-started) | ||
| - [1. On GitHub](#1-on-github) | ||
| - [2. GitHub Codespaces](#2-github-codespaces) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These need adding to the accept.txt in the singular and plural.
|
|
||
| - When you contribute to the project for the first time, please consider checking the [good first issue](https://github.com/mautic/developer-documentation-new/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22good%20first%20issue%22) or [help wanted](https://github.com/mautic/developer-documentation-new/issues?q=is%3Aissue%20state%3Aopen%20label%3A%22help%20wanted%22) labels. | ||
|
|
||
| - If you wish to work on an open issue, please comment on the issue, and a maintainer will assign it to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - If you wish to work on an open issue, please comment on the issue, and a maintainer will assign it to you. | |
| - If you wish to work on an open issue, please comment on the issue, and wait to be assigned by a maintainer. |
|
|
||
| If an issue isn't assigned, it's assumed to be available for anyone to work on. So, ensure that you're assigned to an issue **before** beginning work to avoid conflicts. | ||
|
|
||
| **Note:** Please don't ask maintainers to assign you to another issue before you have finished working on yours and created a PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| **Note:** Please don't ask maintainers to assign you to another issue before you have finished working on yours and created a PR. | |
| **Note:** please don't ask maintainers to assign you to another issue before you have finished working on yours and created a PR. |
Could we use an admonition here?
|
|
||
|  | ||
|
|
||
| 3. Uncheck the option of 'Copy the DEFAULT-BRANCH-NAME branch only' because later on, you want to be able to clone multiple branches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| 3. Uncheck the option of 'Copy the DEFAULT-BRANCH-NAME branch only' because later on, you want to be able to clone multiple branches. | |
| 3. Remove the check in the option of 'Copy the DEFAULT-BRANCH-NAME branch only' because later on, you want to be able to clone multiple branches. |
|
|
||
| 4. Click the green 'Create fork' button at the bottom. | ||
|
|
||
|  |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|  | |
|  |
| # Mautic developer documentation (new) | ||
|
|
||
| This repository hosts the new developer documentation for Mautic on the [Read the Docs platform][ReadTheDocs]. Whenever a PR is merged, changes are deployed immediately to https://mautic-developer.readthedocs.io/ | ||
| This repository hosts the new developer documentation for Mautic on the [Read the Docs platform][ReadTheDocs]. Whenever a PR is merged, changes are deployed immediately to https://devdocs.mautic.org/. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| This repository hosts the new developer documentation for Mautic on the [Read the Docs platform][ReadTheDocs]. Whenever a PR is merged, changes are deployed immediately to https://devdocs.mautic.org/. | |
| This repository hosts the new developer documentation for Mautic on the [Read the Docs platform][ReadTheDocs]. Builds take a few minutes to run before changes show on https://devdocs.mautic.org following the merging of a PR. Each PR has a GitHub Action which spins up a temporary environment for reviewing the changes. |
| @@ -1,110 +1,20 @@ | |||
| [![Documentation Status][RTD badge URL]][RTD URL] [](#contributors) | |||
|
|
|||
| # Mautic developer documentation (new) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # Mautic developer documentation (new) | |
| # Mautic developer documentation |
I think we can remove the 'new' part now.
| This repository hosts the new developer documentation for Mautic on the [Read the Docs platform][ReadTheDocs]. Whenever a PR is merged, changes are deployed immediately to https://mautic-developer.readthedocs.io/ | ||
| This repository hosts the new developer documentation for Mautic on the [Read the Docs platform][ReadTheDocs]. Whenever a PR is merged, changes are deployed immediately to https://devdocs.mautic.org/. | ||
|
|
||
| If you're looking for the legacy developer documentation, please go to https://developer.mautic.org/ or the [GitHub repository][Legacy dev docs]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| If you're looking for the legacy developer documentation, please go to https://developer.mautic.org/ or the [GitHub repository][Legacy dev docs]. | |
| If you're looking for the legacy developer documentation, please go to https://developer.mautic.org/ or the [GitHub repository][Legacy dev docs]. This still exists because we have some changes which haven't yet been ported over to the new documentation here - if you'd like to help please check the [contribution guidelines](.github/CONTRIBUTING.md). |
| ## Contributing 🤝 | ||
|
|
||
| Mautic's documentation uses ``reStructuredText``, or ``.rst`` files. Luckily, there's converters available that help you convert ``.md`` to ``.rst`` files. Here's an example of ``m2r`` - this converter also converts tables into ``list-table`` directives properly. | ||
| All kinds of contributions are encouraged. For complete information on how to contribute to the Mautic developer documentation (new) repository, please read the [Contributing Guidelines](.github/CONTRIBUTING.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| All kinds of contributions are encouraged. For complete information on how to contribute to the Mautic developer documentation (new) repository, please read the [Contributing Guidelines](.github/CONTRIBUTING.md). | |
| Mautic actively encourages all kinds of contributions. For complete information on how to contribute to the Mautic developer documentation repository, please read the [Contributing Guidelines](.github/CONTRIBUTING.md). |
| # This creates a new file with the .rst extension: | ||
| m2r my_markdown_file.md | ||
| ``` | ||
| All contributors are required to abide by our [Code of Conduct](https://mautic.org/code-of-conduct/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| All contributors are required to abide by our [Code of Conduct](https://mautic.org/code-of-conduct/). | |
| All contributors must abide by the Mautic [Code of Conduct](https://mautic.org/code-of-conduct/). |
|
@RCheesley thanks so much for the suggestion! I'll apply them soon and let you know when they're ready. 👍🏼 In the meantime, I'd like to explain why I do below details across our docs:
AdmonitionsApplying GitHub admonitions for notes, tip, or warnings as part of the list does:
Here are some screenshot of examples: 1. Admonition as part of unordered listAs you can see, the admonition is out of the flow.
2. Admonition as part of ordered listImage 1Just like the example in unordered list, the admonition is out of the flow.
Image 2After the admonition, all instructions are still belong to point 4. But the indentation follows the admonition instead of the point. This can cause confusions.
Image 3For this one, I indent the admonition just like we indent a paragraph that's part of a point. The indentation works great, but the admonition breaks.
The
|




Description
This PR holds below changes:
.githubfolder.Linked issue
Closes #272
Closes #279
Screenshots or screen recordings