Skip to content

Conversation

@Kshitij-Katiyar
Copy link
Contributor

Summary

Webapp testcase setup and added web app test cases for the following UI components:

  • Github assignee selector
  • Github label selector
  • Github milestone selector
  • Github repo selector

@Kshitij-Katiyar Kshitij-Katiyar added the 2: Dev Review Requires review by a core committer label Dec 17, 2024
@Kshitij-Katiyar Kshitij-Katiyar self-assigned this Dec 17, 2024
@Kshitij-Katiyar Kshitij-Katiyar changed the title Mm 1007 [MM-1007]: Web app test cases setup and added web app test cases for some UI components Dec 17, 2024
@hanzei
Copy link
Contributor

hanzei commented Jan 6, 2025

@rahimrahman I wonder if you have thoughts on the general setup of the test cases, given that you worked a lot of webapp test recently.

@rahimrahman
Copy link

@hanzei thanks for flagging me.

@Kshitij-Katiyar few things:

  • let's use @testing-library/react instead of enzyme. Enzyme will not work with React 17+ (React 19 has just been released).
  • let's eliminate the use of toMatchSnapshot() for more meaningful test.

@Kshitij-Katiyar
Copy link
Contributor Author

@hanzei thanks for flagging me.

@Kshitij-Katiyar few things:

  • let's use @testing-library/react instead of enzyme. Enzyme will not work with React 17+ (React 19 has just been released).
  • let's eliminate the use of toMatchSnapshot() for more meaningful test.

@rahimrahman Sure will update the test cases with the changes

Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please re-add me as a reviewer when the PR is ready.

@abbas-dependable-naqvi
Copy link
Contributor

@hanzei thanks for flagging me.

@Kshitij-Katiyar few things:

  • let's use @testing-library/react instead of enzyme. Enzyme will not work with React 17+ (React 19 has just been released).
  • let's eliminate the use of toMatchSnapshot() for more meaningful test.

Due to these changes, i don't think this PR is much useful, It would be better to build this from scratch.
Still keeping this PR open for context

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2: Dev Review Requires review by a core committer Lifecycle/1:stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants