-
Notifications
You must be signed in to change notification settings - Fork 354
feat(base,sdk): Support for dirty cross-process lock in the EventCache
#5856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Hywan
wants to merge
25
commits into
matrix-org:main
Choose a base branch
from
Hywan:feat-cross-process-lock-event-cache
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,249
−922
Open
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
88f67e4
chore(common) Rename `CrossProcessLockKind` to `CrossProcessLockState`.
Hywan 14aad28
feat(common) Add `#[must_use]` on `CrossProcessLockGuard` and `*State`.
Hywan 6a2af4a
feat(common): Add `CrossProcessLockState::map`.
Hywan 9c46b96
feat(base) Create the `EventCacheStoreLockState` type.
Hywan 7ea191d
chore(sdk): Clean up imports.
Hywan 32f136b
feat(common): Add `CrossProcessLockGuard::is_dirty` and `::clear_dirty`.
Hywan f5710f4
feat(base): Add `EventCacheStoreLockGuard::clear_dirty`.
Hywan 87fa020
refactor(base): `EventCacheStoreLockState` owns a clone of the inner …
Hywan a48edd2
feat(common): `CrossProcessLockGuard` can be cloned.
Hywan ea3798a
feat(base): `EventCacheStoreLockGuard` can be cloned.
Hywan 07b095d
fix(base): Use the `EventCacheStoreLockState`.
Hywan 8b612cc
test(sdk): Update to use `EventCacheStoreLockState`.
Hywan 56706ac
refactor(sdk) Introduce `RoomEventCacheStateLock` and read/write guards.
Hywan 046e05f
feat(sdk): Reset `RoomEventCacheState` when the cross-process lock is…
Hywan 3c4afc1
doc(sdk): Add missing or fix documentation.
Hywan f288e5f
fix(sdk): Remove a warning for `wasm32`.
Hywan 8ee41f4
test(common): Test dirtiness of the cross-process lock.
Hywan ebbd1fe
test(common): Make tests run faster.
Hywan 900f084
feat(sdk): Implement `RoomEventCacheStateLockWriteGuard::downgrade`.
Hywan 6163013
feat(sdk): Allow shared access on `RoomEventCacheStateLock::read`.
Hywan cf881ab
test(sdk): Add the `test_reset_when_dirty` test.
Hywan 7a163c1
refactor(sdk): Rename `RoomEventCacheInner::sender` to `update_sender`.
Hywan a32724b
feat(sdk): Send updates when `RoomEventCacheStateLock` is reloaded.
Hywan a6eae60
test(sdk): Ensure `EventCacheStoreLockGuard::clear_dirty` is called!
Hywan 82fd99d
test(sdk): Add a test for dirtiness handling in `RoomEventCacheStateL…
Hywan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.