Skip to content

WASM Improvements #5838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

WASM Improvements #5838

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
463589e
fix(matrix-sdk-ffi): remove bundled-sqlite from default features
MTRNord Nov 6, 2025
b87c179
fix(matrix-sdk-ffi): fix depenendencies for the wasm bindings
MTRNord Nov 6, 2025
a964f09
fix(matrix-sdk-ffi): add missing wasm stubs
MTRNord Nov 6, 2025
fd93a0f
chore: remove return keywords as per clippy warnings
MTRNord Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindings/matrix-sdk-ffi/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ crate-type = [
]

[features]
default = ["bundled-sqlite", "unstable-msc4274", "experimental-element-recent-emojis"]
default = ["unstable-msc4274", "experimental-element-recent-emojis"]
Copy link
Contributor

@poljar poljar Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? Can't you use --no-default-features to get the feature set you'd want/need on Wasm?

Therefor we probably
shouldn't have it as the default since indexeddb support was added.

Why not? The defaults are here to serve the most common use-case. Having only the memory store by default seems like a worse situation.

The matrix-sdk crate also enables SQLite support by default, even though it ~always supported IndexedDB.

# Use SQLite for the session storage.
sqlite = ["matrix-sdk/sqlite"]
# Use an embedded version of SQLite.
Expand Down