chore: remove setAccessible reflection method calls, that do nothing in test

[landure]

Since PHP 8.1, setAccessible() reflection methods have no effect. The CI fails on rector RemoveReflectionSetAccessibleCallsRector rule.

This pull request remove the setAccessible() calls.

Summary by CodeRabbit

• Tests
  • Streamlined unit tests by removing redundant reflective access overrides and simplifying invocation flow, reducing brittleness and improving maintainability.
  • Clarified test intent without altering production behavior.
  • No changes to public APIs or user-facing functionality; existing features remain unaffected.
  • Improves the resilience of the test suite against future refactors.

[coderabbitai]

Walkthrough

Test updates remove explicit Reflection setAccessible(true) calls in BaseVariadicFunctionTestCase, invoking methods without forcing accessibility.

Changes

Cohort / File(s)	Summary of changes
Test reflection adjustments tests/Unit/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/BaseVariadicFunctionTestCase.php	Removed three setAccessible(true) calls for ReflectionMethod/ReflectionClass. Reflective invocations proceed without altering accessibility in tests for lookahead type and argument count validation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• fix: wrap up ORM v3 throwable when parsing fails in variadic functions #285 — Touches feedParserWithNodes and parser exception handling, overlapping with tests invoking feedParserWithNodes.
• refactor: stricter method argument types when handling variadic functions #343 — Adjusts validateArguments/feedParserWithNodes signatures, aligning with tests removing accessibility overrides for these methods.
• refactor: allow node mapping in variadic functions to have different patterns, thus opening the path to a combination of node types (compared to the previous single type support) #349 — Refactors BaseVariadicFunction node mapping; tests here interact with the same methods now accessed without setAccessible.

Poem

A rabbit taps keys with delicate care,
Snipping old locks from methods laid bare.
No secret doors, no sneaky peeks—
Just open calls and simpler tweaks.
Thump-thump! the tests now swiftly run,
Ears up high—another job well done. 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these settings in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 33d7d14 and 0ec2ab4.

📒 Files selected for processing (1)

• tests/Unit/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/BaseVariadicFunctionTestCase.php (0 hunks)

💤 Files with no reviewable changes (1)

• tests/Unit/MartinGeorgiev/Doctrine/ORM/Query/AST/Functions/BaseVariadicFunctionTestCase.php

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)

• GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer latest
• GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer 3.0
• GitHub Check: PHP 8.4 + Doctrine ORM 2.18 + Doctrine Lexer 2.1
• GitHub Check: PHP 8.4 + Doctrine ORM latest + Doctrine Lexer 2.1
• GitHub Check: PHP 8.2 + Doctrine ORM 3.0 + Doctrine Lexer latest
• GitHub Check: PHP 8.3 + Doctrine ORM latest + Doctrine Lexer latest
• GitHub Check: PHP 8.3 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
• GitHub Check: PHP 8.2 + Doctrine ORM 2.14 + Doctrine Lexer latest
• GitHub Check: PHP 8.1 + Doctrine ORM 2.18 + Doctrine Lexer latest
• GitHub Check: PHP 8.3 + Doctrine ORM 2.14 + Doctrine Lexer 2.1
• GitHub Check: PHP 8.1 + Doctrine ORM 3.0 + Doctrine Lexer 3.0
• GitHub Check: PHP 8.1 + Doctrine ORM latest + Doctrine Lexer 3.0
• GitHub Check: sloth

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coveralls]

coverage: 94.65%. remained the same
when pulling 0ec2ab4 on biapy:fix-remove-reflection-set-accessible
into 33d7d14 on martin-georgiev:main.